Issue 6755009: ARM: Check for minus zero when converting binary operation result to smi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6755009: ARM: Check for minus zero when converting binary operation result to smi (Closed)

Created:
9 years, 9 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Check for minus zero when converting binary operation result to smi The result of an Int32 binary operation will be converted to a smi if it fits. However a minus zero check was missing. BUG=v8:1278 TEST=test/mjsunit/regress/regress-1278.js R=ager@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=7399

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -0 lines)			Patch
	M	src/arm/code-stubs-arm.cc	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download
	A	test/mjsunit/regress/regress-1278.js	View	1	1 chunk	+69 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages