Relax |const NSClass*| PRESUBMIT check to not detect false positives

presubmit_canned_checks.py

 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 
 ### Description checks
 
 def CheckChangeHasTestField(input_api, output_api):
@@ skipping 706 matching lines @@
   approvers = []
   for m in messages:
     sender = m['sender']
     if _IsApprovingComment(m['text']) and match_reviewer(sender):
       approvers.append(sender)
   return set(approvers)
 
 
 def _CheckConstNSObject(input_api, output_api, source_file_filter):
   """Checks to make sure no objective-c files have |const NSSomeClass*|."""
-  pattern = input_api.re.compile(r'const\s+NS\w*\s*\*')
+  pattern = input_api.re.compile(
+      r'const\s+NS(?!(Point|Range|Rect|Size)\s*\*)\w*\s*\*')
 
   def objective_c_filter(f):
     return (source_file_filter(f) and
-            input_api.os_path.splitext(f.LocalPath())[1] in ('.h', '.mm'))
+            input_api.os_path.splitext(f.LocalPath())[1] in ('.h', '.m', '.mm'))
 
   files = []
   for f in input_api.AffectedSourceFiles(objective_c_filter):
     contents = input_api.ReadFile(f)
     if pattern.search(contents):
       files.append(f)
 
   if files:
     if input_api.is_committing:
       res_type = output_api.PresubmitPromptWarning
@@ skipping 86 matching lines @@
       input_api, output_api, source_file_filter=text_files))
   results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckLicense(
       input_api, output_api, license_header, source_file_filter=sources))
   results.extend(_CheckConstNSObject(
       input_api, output_api, source_file_filter=sources))
   results.extend(_CheckSingletonInHeaders(
       input_api, output_api, source_file_filter=sources))
   return results