Issue 6755004: Revert 79517 -- Because it broke the build. - Pulling in latest gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6755004: Revert 79517 -- Because it broke the build. - Pulling in latest gyp. (Closed)

Created:
9 years, 9 months ago by levin

Modified:
9 years, 7 months ago

Reviewers:
bradn

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 79517 -- Because it broke the build. - Pulling in latest gyp. Switches action attachment rule back to something like pre-r901. BUG=http://code.google.com/p/chromium/issues/detail?id=77555 TEST=None TBR=jeanluc Review URL: http://codereview.chromium.org/6739003 TBR=bradnelson@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79523

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

levin

See http://build.chromium.org/p/chromium/builders/Win/builds/3342/steps/compile/logs/stdio

9 years, 9 months ago (2011-03-28 01:16:03 UTC) #2

bradn

9 years, 9 months ago (2011-03-28 16:01:50 UTC) #3

Sorry about that.
It had gotten thru a compile on a clobber try run, so I'm particularly
confused.
Thanks for reverting.

-BradN

On Sun, Mar 27, 2011 at 6:16 PM, <levin@chromium.org> wrote:

> See
>
>
http://build.chromium.org/p/chromium/builders/Win/builds/3342/steps/compile/l...
>
>
>
> http://codereview.chromium.org/6755004/
>

Expand Messages | Collapse Messages