Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: git_cl/PRESUBMIT.py

Issue 6755003: Disable owners.sh for now since it's known to fail. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl/PRESUBMIT.py
diff --git a/git_cl/PRESUBMIT.py b/git_cl/PRESUBMIT.py
index c37dce22c07658e89251d9e2c981cb44548b9fa8..501ea1f8bce045ed86b6d49867123c74ea992815 100644
--- a/git_cl/PRESUBMIT.py
+++ b/git_cl/PRESUBMIT.py
@@ -48,10 +48,11 @@ def RunTests(input_api, output_api):
test_path = input_api.os_path.abspath(
input_api.os_path.join(input_api.PresubmitLocalPath(), 'test'))
for test in listdir(test_path):
- # push-from-logs and rename fails for now. Remove from this list once
- # they work.
- if (test in ('push-from-logs.sh', 'rename.sh', 'test-lib.sh') or
- not test.endswith('.sh')):
+ # test-lib.sh is not an actual test so it should not be run. The other
+ # tests are tests known to fail.
+ DISABLED_TESTS = (
+ 'owners.sh', 'push-from-logs.sh', 'rename.sh', 'test-lib.sh')
+ if test in DISABLED_TESTS or not test.endswith('.sh'):
continue
print('Running %s' % test)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698