Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: chrome/test/render_view_test.cc

Issue 6750018: Cleanup: Stop creating RenderViewObservers from chrome/ in RenderViewer. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix build on win/mac Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/render_view_test.cc
===================================================================
--- chrome/test/render_view_test.cc (revision 79652)
+++ chrome/test/render_view_test.cc (working copy)
@@ -16,6 +16,7 @@
#include "chrome/renderer/extensions/js_only_v8_extensions.h"
#include "chrome/renderer/extensions/renderer_extension_bindings.h"
#include "chrome/renderer/mock_render_process.h"
+#include "chrome/renderer/print_web_view_helper.h"
#include "chrome/renderer/renderer_main_platform_delegate.h"
#include "content/common/dom_storage_common.h"
#include "content/common/native_web_keyboard_event.h"
@@ -135,23 +136,20 @@
// This needs to pass the mock render thread to the view.
view_ = RenderView::Create(&render_thread_,
- 0,
- kOpenerId,
- RendererPreferences(),
WebPreferences(),
new SharedRenderViewCounter(0),
kRouteId,
- kInvalidSessionStorageNamespaceId,
- string16());
+ kInvalidSessionStorageNamespaceId);
+ view_->Init(0, kOpenerId, RendererPreferences(), string16(), NULL, NULL);
// Attach a pseudo keyboard device to this object.
mock_keyboard_.reset(new MockKeyboard());
- // RenderView doesn't expose it's PasswordAutofillManager or
- // AutofillAgent objects, because it has no need to store them directly
- // (they're stored as RenderViewObserver*). So just create another set.
+ // These RenderViewObserver are normally created in RenderViewWrapper.
+ // Manually creating them here.
password_autofill_ = new PasswordAutofillManager(view_);
autofill_agent_ = new AutofillAgent(view_, password_autofill_);
+ print_helper_ = new PrintWebViewHelper(view_);
}
void RenderViewTest::TearDown() {

Powered by Google App Engine
This is Rietveld 408576698