Cleanup: Stop creating RenderViewObservers from chrome/ in RenderViewer.

chrome/renderer/render_thread.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/render_thread.h"
 
 #include <algorithm>
 #include <limits>
 #include <map>
+#include <set>

[jam, 2011/03/29 18:31:59]

nit: needed?

[Lei Zhang, 2011/03/30 22:05:43]

I was following the linter, but it's a moot point since I reverted all changes
to render_thread.cc.

 #include <vector>
 
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/stats_table.h"
 #include "base/process_util.h"
 #include "base/shared_memory.h"
@@ skipping 17 matching lines @@
 #include "chrome/renderer/extension_groups.h"
 #include "chrome/renderer/extensions/chrome_app_bindings.h"
 #include "chrome/renderer/extensions/event_bindings.h"
 #include "chrome/renderer/extensions/extension_process_bindings.h"
 #include "chrome/renderer/extensions/js_only_v8_extensions.h"
 #include "chrome/renderer/extensions/renderer_extension_bindings.h"
 #include "chrome/renderer/external_extension.h"
 #include "chrome/renderer/loadtimes_extension_bindings.h"
 #include "chrome/renderer/net/renderer_net_predictor.h"
 #include "chrome/renderer/render_process_impl.h"
+#include "chrome/renderer/render_view_wrapper.h"

[jam, 2011/03/29 18:31:59]

I'm actually working on removing all the chrome dependencies from RenderThread,
so that I can move it to content (a lot of it is not chrome specific, and will
be needed there, so I don't want to duplicate it).  so my thinking was we would
call through the embedder api (i.e. ContentRendererClient) to inform the
embedder that a RenderView has been created.  then Chrome can add its list of
observers

[Lei Zhang, 2011/03/30 22:05:43]

Ok. I did that in the next patchset.

 #include "chrome/renderer/renderer_histogram_snapshots.h"
 #include "chrome/renderer/safe_browsing/phishing_classifier_delegate.h"
 #include "chrome/renderer/search_extension.h"
 #include "chrome/renderer/searchbox_extension.h"
 #include "chrome/renderer/security_filter_peer.h"
 #include "chrome/renderer/spellchecker/spellcheck.h"
 #include "chrome/renderer/user_script_slave.h"
 #include "content/common/appcache/appcache_dispatcher.h"
 #include "content/common/database_messages.h"
 #include "content/common/db_message_filter.h"
@@ skipping 677 matching lines @@
        ++it, ++i) {
     color_names[i] = it->first;
     web_colors[i] = it->second;
   }
   WebKit::setNamedColors(color_names.get(), web_colors.get(), num_colors);
 }
 
 void RenderThread::OnCreateNewView(const ViewMsg_New_Params& params) {
   EnsureWebKitInitialized();
   // When bringing in render_view, also bring in webkit's glue and jsbindings.
-  RenderView::Create(
+  RenderView* rv = RenderView::Create(
       this,
-      params.parent_window,
-      MSG_ROUTING_NONE,
-      params.renderer_preferences,
       params.web_preferences,
       new SharedRenderViewCounter(0),
       params.view_id,
-      params.session_storage_namespace_id,
-      params.frame_name);
+      params.session_storage_namespace_id);
+  // RenderViewWrapper implements the RenderViewObserver interface and shares
+  // the lifetime of |rv|.
+  new RenderViewWrapper(rv,
+                        params.parent_window,
+                        MSG_ROUTING_NONE,
+                        params.renderer_preferences,
+                        params.frame_name);
 }
 
 void RenderThread::OnSetCacheCapacities(size_t min_dead_capacity,
                                         size_t max_dead_capacity,
                                         size_t capacity) {
   EnsureWebKitInitialized();
   WebCache::setCapacities(
       min_dead_capacity, max_dead_capacity, capacity);
 }
 
@@ skipping 434 matching lines @@
   }
 
   return false;
 }
 
 void RenderThread::RegisterExtension(v8::Extension* extension,
                                      bool restrict_to_extensions) {
   WebScriptController::registerExtension(extension);
   v8_extensions_[extension->name()] = restrict_to_extensions;
 }