Add a RenderProcessObserver. For now this will be primarily used to filter control messages, so ...

Add a RenderProcessObserver.  For now this will be primarily used to filter control messages, so that we can take out the chrome specific message dispatching out of RenderThread.  It will also be used to clean up RenderThread a bit.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79565

[brettw, 2011-03-26 18:08:48]

http://codereview.chromium.org/6750014/diff/1002/chrome/renderer/render_thread.h
File chrome/renderer/render_thread.h (right):

http://codereview.chromium.org/6750014/diff/1002/chrome/renderer/render_threa...
chrome/renderer/render_thread.h:419: RenderProcessObserverList observers_;
I wonder if this should be a base::ObserverList in case one of the callbacks
starts modifying the list in a notification. If we're not worried about
modification, I'd just use a vector which should be less overhead than a list.

http://codereview.chromium.org/6750014/diff/1002/content/renderer/render_proc...
File content/renderer/render_process_observer.cc (right):

http://codereview.chromium.org/6750014/diff/1002/content/renderer/render_proc...
content/renderer/render_process_observer.cc:10: bool
RenderProcessObserver::OnControlMessageReceived(const IPC::Message& message) {
Too long.

[jam, 2011-03-27 22:55:47]

http://codereview.chromium.org/6750014/diff/1002/chrome/renderer/render_thread.h
File chrome/renderer/render_thread.h (right):

http://codereview.chromium.org/6750014/diff/1002/chrome/renderer/render_threa...
chrome/renderer/render_thread.h:419: RenderProcessObserverList observers_;
On 2011/03/26 18:08:48, brettw wrote:
> I wonder if this should be a base::ObserverList in case one of the callbacks
> starts modifying the list in a notification. If we're not worried about
> modification, I'd just use a vector which should be less overhead than a list.

I've switched to ObserverList just to be safe.

http://codereview.chromium.org/6750014/diff/1002/content/renderer/render_proc...
File content/renderer/render_process_observer.cc (right):

http://codereview.chromium.org/6750014/diff/1002/content/renderer/render_proc...
content/renderer/render_process_observer.cc:10: bool
RenderProcessObserver::OnControlMessageReceived(const IPC::Message& message) {
On 2011/03/26 18:08:48, brettw wrote:
> Too long.

Done.

[brettw, 2011-03-28 16:17:54]

LGTM

http://codereview.chromium.org/6750014/diff/10001/chrome/renderer/render_thre...
File chrome/renderer/render_thread.cc (right):

http://codereview.chromium.org/6750014/diff/10001/chrome/renderer/render_thre...
chrome/renderer/render_thread.cc:651: while ((observer = it.GetNext()) != NULL)
Need {} for this while.