Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 6749034: Make NSS for Chromium build properly for Mac x86_64 (Closed)

Created:
9 years, 9 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
wtc
CC:
chromium-reviews
Visibility:
Public.

Description

Make NSS for Chromium build properly for Mac x86_64. BUG=18323 TEST=My own 'ARCHS': ['x86_64'] build. Chromium now builds up through base_unittests for x86_64, and all base_unittests pass except for those tests also marked FAILS_ for x86. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79733

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M nss.gyp View 1 4 chunks +19 lines, -12 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Mark Mentovai
This includes http://codereview.chromium.org/6765014/. I patched it in locally and then worked off of it. I ...
9 years, 9 months ago (2011-03-29 19:46:27 UTC) #1
Mark Mentovai
Since you’ve shown me where to find the definition of i386 in the NSS build ...
9 years, 9 months ago (2011-03-29 19:54:16 UTC) #2
wtc
LGTM. Feel free to commit this CL first. I can abandon my CL. (I may ...
9 years, 9 months ago (2011-03-29 20:02:52 UTC) #3
Mark Mentovai
9 years, 9 months ago (2011-03-29 20:33:31 UTC) #4
I’d like to check this in as-is to match the upstream and then investigate
whether the mpi_amd64.c concern ought to be addressed in the upstream NSS build.

Powered by Google App Engine
This is Rietveld 408576698