Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: src/scanner-base.h

Issue 6749029: Make the preparser standalone library and process build in debug mode. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comment. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/scanner.cc ('k') | src/scanner-base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/scanner-base.h
diff --git a/src/scanner-base.h b/src/scanner-base.h
index 7203569770aa7987e0a8b73e1e2322b320c55303..552f3873d31911e25b961cc2f8b8ddc826cf1b86 100644
--- a/src/scanner-base.h
+++ b/src/scanner-base.h
@@ -123,6 +123,7 @@ class ScannerConstants {
// ---------------------------------------------------------------------
// Constants used by scanners.
public:
+ ScannerConstants() {}
typedef unibrow::Utf8InputBuffer<1024> Utf8Decoder;
StaticResource<Utf8Decoder>* utf8_decoder() {
@@ -137,7 +138,6 @@ class ScannerConstants {
bool IsIdentifier(unibrow::CharacterStream* buffer);
private:
- ScannerConstants() {}
unibrow::Predicate<IdentifierStart, 128> kIsIdentifierStart;
unibrow::Predicate<IdentifierPart, 128> kIsIdentifierPart;
@@ -145,7 +145,6 @@ class ScannerConstants {
unibrow::Predicate<unibrow::WhiteSpace, 128> kIsWhiteSpace;
StaticResource<Utf8Decoder> utf8_decoder_;
- friend class Isolate;
DISALLOW_COPY_AND_ASSIGN(ScannerConstants);
};
@@ -273,7 +272,7 @@ class Scanner {
bool complete_;
};
- explicit Scanner(Isolate* isolate);
+ explicit Scanner(ScannerConstants* scanner_contants);
// Returns the current token again.
Token::Value current_token() { return current_.token; }
@@ -474,7 +473,7 @@ class JavaScriptScanner : public Scanner {
bool complete_;
};
- explicit JavaScriptScanner(Isolate* isolate);
+ explicit JavaScriptScanner(ScannerConstants* scanner_contants);
// Returns the next token.
Token::Value Next();
« no previous file with comments | « src/scanner.cc ('k') | src/scanner-base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698