Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 6749029: Make the preparser standalone library and process build in debug mode. (Closed)

Created:
9 years, 9 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Make the preparser standalone library and process build in debug mode. It should now be possible to build the preparser using 'scons preparser' in both release and debug modes. Remove v8.h include from scanner-base.h and other files. Remove NativeAllocationChecker and all of its kind. Moved Isolate::PreallocatedStorage* to isolate.cc Committed: http://code.google.com/p/v8/source/detail?r=7413

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -186 lines) Patch
M src/allocation.h View 2 chunks +0 lines, -20 lines 0 comments Download
M src/allocation.cc View 2 chunks +0 lines, -113 lines 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/isolate.cc View 1 chunk +71 lines, -0 lines 0 comments Download
M src/objects.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/parser.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/preparse-data.cc View 1 chunk +1 line, -8 lines 0 comments Download
src/preparser.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/preparser-api.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M src/scanner.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/scanner.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/scanner-base.h View 5 chunks +3 lines, -4 lines 0 comments Download
M src/scanner-base.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M src/top.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M test/cctest/test-parsing.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
9 years, 9 months ago (2011-03-29 12:28:53 UTC) #1
Vitaly Repeshko
LGTM http://codereview.chromium.org/6749029/diff/1/src/preparser-api.cc File src/preparser-api.cc (right): http://codereview.chromium.org/6749029/diff/1/src/preparser-api.cc#newcode163 src/preparser-api.cc:163: : JavaScriptScanner(&scanner_constants_), scanner_constants_() { } This passes a ...
9 years, 9 months ago (2011-03-29 12:33:22 UTC) #2
Lasse Reichstein
9 years, 9 months ago (2011-03-29 13:29:55 UTC) #3
http://codereview.chromium.org/6749029/diff/1/src/preparser-api.cc
File src/preparser-api.cc (right):

http://codereview.chromium.org/6749029/diff/1/src/preparser-api.cc#newcode163
src/preparser-api.cc:163: : JavaScriptScanner(&scanner_constants_),
scanner_constants_() { }
Yeah, it's a bit iffy. It should work (the address is safe and it isn't
dereferenced in the constructor), but it's probably safer to make it heap
allocated. But then I need a place to store the pointer, so that it can be freed
again, which would be unallocated storage too. :(
It's probably even better to just let the StandAlone...Scanner get a scanner
constant pointer as argument.

Powered by Google App Engine
This is Rietveld 408576698