Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 6749025: Update rietveld to r681. (Closed)

Created:
9 years, 9 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, M-A Ruel, Evan Martin
Visibility:
Public.

Description

Update rietveld to r681. Remove django since it's not necessary anymore, rietveld now uses django 1.2 and it's included in GAE SDK. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -18 lines) Patch
M git_cl/test/local_rietveld.py View 5 chunks +21 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
I've uploaded simply so you can help me here. The tests are broken with more ...
9 years, 9 months ago (2011-03-26 01:25:42 UTC) #1
M-A Ruel
Ok I've figured out the issue, I had the old django version in depot_tools/git_cl/tests/rietveld/django that ...
9 years, 9 months ago (2011-03-27 20:48:01 UTC) #2
Dirk Pranke
9 years, 9 months ago (2011-03-28 00:06:45 UTC) #3
LGTM.

I would just skip the owners tests for now. They're not very good and I'm about
to revamp the code and the tests anyway (and I'd rather get the updated rietveld
before I do that).

Powered by Google App Engine
This is Rietveld 408576698