Issue 6749020: Do not enable the use_tablet flag in qemu, as this breaks the mouse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6749020: Do not enable the use_tablet flag in qemu, as this breaks the mouse. (Closed)

Created:
9 years, 9 months ago by marcheu

Modified:
9 years, 7 months ago

Reviewers:
rkc, Daniel Kurtz

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

Do not enable the use_tablet flag in qemu, as this breaks the mouse. Change-Id: I52901180e962c463bdaacbc573f93700cf9ab4bd BUG=None TEST=Run Chrome OS in qemu, check that the mouse is back. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=78bd46d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove fixup_image_for_qemu.py entirely. #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -122 lines)			Patch
	D	fixup_image_for_qemu.py	View	1	1 chunk	+0 lines, -112 lines	0 comments	Download
	M	image_to_vm.sh	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Daniel Kurtz

What about this... http://codereview.chromium.org/6749020/diff/1/image_to_vm.sh File image_to_vm.sh (right): http://codereview.chromium.org/6749020/diff/1/image_to_vm.sh#newcode81 image_to_vm.sh:81: DEFINE_boolean enable_tablet ${FLAGS_FALSE} \ "<copy from ...

9 years, 9 months ago (2011-03-25 23:24:11 UTC) #2

rkc

9 years, 9 months ago (2011-03-25 23:30:56 UTC) #3

Spoke to marcheu about this, the fixup script is now totally unnecessary, he'll
update the CL to remove it completely.

LGTM once the fixup script is removed.

On 2011/03/25 23:24:11, Daniel Kurtz wrote:
> What about this...
> 
> http://codereview.chromium.org/6749020/diff/1/image_to_vm.sh
> File image_to_vm.sh (right):
> 
> http://codereview.chromium.org/6749020/diff/1/image_to_vm.sh#newcode81
> image_to_vm.sh:81: 
> DEFINE_boolean enable_tablet ${FLAGS_FALSE} \
>    "<copy from f_i_f_q>"
> 
> http://codereview.chromium.org/6749020/diff/1/image_to_vm.sh#newcode194
> image_to_vm.sh:194: --enable_tablet=false
> --enable_tablet="${enable_tablet}"

Expand Messages | Collapse Messages