Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 6746008: Move all dev tools messages to devtools_messages.h and create a TabHelper to filter their message... (Closed)

Created:
9 years, 9 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Move all dev tools messages to devtools_messages.h and create a TabHelper to filter their messages to that RenderViewHost doesn't have to know about devtools. TBR=pfeldman Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79468

Patch Set 1 #

Patch Set 2 : take out unnecessary includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -132 lines) Patch
M chrome/browser/debugger/devtools_manager.h View 4 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/debugger/devtools_manager.cc View 2 chunks +9 lines, -0 lines 0 comments Download
A chrome/browser/debugger/devtools_tab_helper.h View 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/debugger/devtools_tab_helper.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/devtools_messages.h View 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 1 4 chunks +0 lines, -52 lines 0 comments Download
M chrome/renderer/devtools_agent.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/renderer/devtools_client.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_view_host.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 4 chunks +0 lines, -50 lines 0 comments Download
M content/renderer/render_view.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
this is part of the work of driving the number of messages in render_messages.h to ...
9 years, 9 months ago (2011-03-25 21:54:56 UTC) #1
pfeldman
Not LGTM. See http://src.chromium.org/viewvc/chrome?view=rev&revision=79468.
9 years, 8 months ago (2011-03-30 14:37:01 UTC) #2
pfeldman
I.e. see http://code.google.com/p/chromium/issues/detail?id=77615
9 years, 8 months ago (2011-03-30 14:37:18 UTC) #3
jam
9 years, 8 months ago (2011-03-30 15:43:54 UTC) #4
looking into it now, sorry for the breakage.  it's too bad there aren't any
tests that cover this case.

On Wed, Mar 30, 2011 at 7:37 AM, <pfeldman@chromium.org> wrote:

> I.e. see http://code.google.com/p/chromium/issues/detail?id=77615
>
>
> http://codereview.chromium.org/6746008/
>

Powered by Google App Engine
This is Rietveld 408576698