Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 6745031: Revert 79470 - Ensure that BrowserMessageFilter isn't used to process a sync message on the UI th... (Closed)

Created:
9 years, 9 months ago by Ryan Sleevi
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, jam
Visibility:
Public.

Description

Revert 79470 - Ensure that BrowserMessageFilter isn't used to process a sync message on the UI thread. Review URL: http://codereview.chromium.org/6713121 TBR=jam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -36 lines) Patch
M content/browser/browser_message_filter.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/browser_message_filter.cc View 3 chunks +0 lines, -29 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 2 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
9 years, 9 months ago (2011-03-26 06:10:52 UTC) #1
Ryan Sleevi
jam: This caused all of the Windows bots to fail with UITestCanLaunchWithOSMesa. I reverted this ...
9 years, 9 months ago (2011-03-26 06:16:10 UTC) #2
Ryan Sleevi
On 2011/03/26 06:16:10, Ryan Sleevi wrote: > jam: This caused all of the Windows bots ...
9 years, 9 months ago (2011-03-26 06:21:04 UTC) #3
jam
9 years, 9 months ago (2011-03-26 19:15:48 UTC) #4
thanks, i incorrectly assumed this was a flakey test on the trybot run!

On Fri, Mar 25, 2011 at 11:16 PM, <rsleevi@chromium.org> wrote:

> jam: This caused all of the Windows bots to fail with
> UITestCanLaunchWithOSMesa.
> I reverted this CL because, in the original try jobs, it also showed this
> test
> failing.
>
> While this likely highlights a dependency on a sync message for OSMesa, my
> understanding was that it was better to revert this CL than to disable that
> test
> on Windows. I hope this was correct.
>
> Relevant logs:
>
>
>
http://build.chromium.org/p/chromium/builders/Vista%20Tests%20%282%29/builds/...
>
>
> [ RUN      ] GPUUITest.UITestCanLaunchWithOSMesa
> .\test\gpu\gpu_uitest.cc(47): error: Value of: GetActiveTabTitle()
>  Actual: L"FAILED: could not get webgl context for canvas"
> Expected: std::wstring(L"SUCCESS: Mesa OffScreen")
> Which is: L"SUCCESS: Mesa OffScreen"
> [  FAILED  ] GPUUITest.UITestCanLaunchWithOSMesa (541 ms)
>
>
> (Presumably, the renderer is crashing due to a sync message)
>
>
> http://codereview.chromium.org/6745031/
>

Powered by Google App Engine
This is Rietveld 408576698