Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: ppapi/c/private/ppb_flash.h

Issue 6745021: Rename PPB_Flash::NavigateToURL() (to Navigate()) and make it take an URLRequestInfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: doh Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/proxy/ppapi_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/c/private/ppb_flash.h
diff --git a/ppapi/c/private/ppb_flash.h b/ppapi/c/private/ppb_flash.h
index 92ae56f8a541feca88e725134f78b98f3aa3496e..dbea22770dcad9f4e28d3a7ecabc79a45e0ee886 100644
--- a/ppapi/c/private/ppb_flash.h
+++ b/ppapi/c/private/ppb_flash.h
@@ -12,7 +12,7 @@
#include "ppapi/c/pp_resource.h"
#include "ppapi/c/pp_var.h"
-#define PPB_FLASH_INTERFACE "PPB_Flash;7"
+#define PPB_FLASH_INTERFACE "PPB_Flash;8"
struct PPB_Flash {
// Sets or clears the rendering hint that the given plugin instance is always
@@ -35,12 +35,11 @@ struct PPB_Flash {
// be a string in PAC format, or an undefined var on error.
struct PP_Var (*GetProxyForURL)(PP_Instance instance, const char* url);
- // Navigate to URL. May open a new tab if target is not "_self". Return true
- // if success. This differs from javascript:window.open() in that it bypasses
- // the popup blocker, even when this is not called from an event handler.
- PP_Bool (*NavigateToURL)(PP_Instance instance,
- const char* url,
- const char* target);
+ // Navigate to the URL given by the given URLRequestInfo. (This supports GETs,
+ // POSTs, and javascript: URLs.) May open a new tab if target is not "_self".
+ int32_t (*Navigate)(PP_Resource request_info,
+ const char* target,
+ bool from_user_action);
// Runs a nested message loop. The plugin will be reentered from this call.
// This function is used in places where Flash would normally enter a nested
« no previous file with comments | « no previous file | ppapi/proxy/ppapi_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698