Issue 6745021: Rename PPB_Flash::NavigateToURL() (to Navigate()) and make it take an URLRequestInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6745021: Rename PPB_Flash::NavigateToURL() (to Navigate()) and make it take an URLRequestInfo. (Closed)

Created:
9 years, 9 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
piman

CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Rename PPB_Flash::NavigateToURL() (to Navigate()) and make it take an URLRequestInfo. This allows us to navigate using POSTs. BUG=none TEST=works for Trung's Flapper Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79590

Patch Set 1 #

Total comments: 1

Patch Set 2 : doh #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -53 lines)			Patch
M	ppapi/c/private/ppb_flash.h	View		2 chunks	+6 lines, -7 lines	0 comments	Download
M	ppapi/proxy/ppapi_messages.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_proxy.h	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_proxy.cc	View		5 chunks	+26 lines, -16 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View		3 chunks	+25 lines, -14 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_flash_impl.cc	View	1	3 chunks	+17 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

piman

9 years, 9 months ago (2011-03-25 22:07:30 UTC) #2

1 fix then LGTM.

http://codereview.chromium.org/6745021/diff/1/webkit/plugins/ppapi/ppb_flash_...
File webkit/plugins/ppapi/ppb_flash_impl.cc (right):

http://codereview.chromium.org/6745021/diff/1/webkit/plugins/ppapi/ppb_flash_...
webkit/plugins/ppapi/ppb_flash_impl.cc:61: return
BoolToPPBool(instance->Navigate(request, target, from_user_action));
remove BoolToPPBool

Expand Messages | Collapse Messages