Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 6745017: Relax |const NSClass*| PRESUBMIT check to not detect false positives (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
===================================================================
--- PRESUBMIT.py (revision 79435)
+++ PRESUBMIT.py (working copy)
@@ -116,7 +116,8 @@
def _CheckConstNSObject(input_api, output_api, source_file_filter):
"""Checks to make sure no objective-c files have |const NSSomeClass*|."""
- pattern = input_api.re.compile(r'const\s+NS\w*\s*\*')
+ pattern = input_api.re.compile(
+ r'const\s+NS(?!(Point|Range|Rect|Size)\s*\*)\w*\s*\*')
files = []
for f in input_api.AffectedSourceFiles(source_file_filter):
if f.LocalPath().endswith('.h') or f.LocalPath().endswith('.mm'):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698