Relax |const NSClass*| PRESUBMIT check to not detect false positives

Relax |const NSClass*| PRESUBMIT check to not detect false positives when
encountering Foundation types that are not id-derived, including NSPoint,
NSRange, NSRect, and NSSize.

BUG=77438
TEST=Modify chrome/browser/renderer_host/render_widget_host_view_mac.mm

Moved to http://codereview.chromium.org/6755007/ and checked in r79564

[Nico, 2011-03-25 23:14:36]

Lgtm
On Mar 25, 2011 8:53 PM, <mark@chromium.org> wrote:
> Reviewers: Nico,
>
> Description:
> Relax |const NSClass*| PRESUBMIT check to not detect false positives when
> encountering Foundation types that are not id-derived, including NSPoint,
> NSRange, NSRect, and NSSize.
>
> BUG=77438
> TEST=Modify chrome/browser/renderer_host/render_widget_host_view_mac.mm
>
> Please review this at http://codereview.chromium.org/6745017/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
> M PRESUBMIT.py
>
>
> Index: PRESUBMIT.py
> ===================================================================
> --- PRESUBMIT.py (revision 79435)
> +++ PRESUBMIT.py (working copy)
> @@ -116,7 +116,8 @@
>
> def _CheckConstNSObject(input_api, output_api, source_file_filter):
> """Checks to make sure no objective-c files have |const NSSomeClass*|."""
> - pattern = input_api.re.compile(r'const\s+NS\w*\s*\*')
> + pattern = input_api.re.compile(
> + r'const\s+NS(?!(Point|Range|Rect|Size)\s*\*)\w*\s*\*')
> files = []
> for f in input_api.AffectedSourceFiles(source_file_filter):
> if f.LocalPath().endswith('.h') or f.LocalPath().endswith('.mm'):
>
>

[bradn, 2011-03-28 16:44:12]

LGTM