Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: webkit/plugins/ppapi/message_channel.h

Issue 6745015: Make PPAPI PostMessage behave asynchronously. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/tests/test_post_message.cc ('k') | webkit/plugins/ppapi/message_channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/message_channel.h
===================================================================
--- webkit/plugins/ppapi/message_channel.h (revision 79483)
+++ webkit/plugins/ppapi/message_channel.h (working copy)
@@ -5,6 +5,7 @@
#ifndef WEBKIT_PLUGINS_PPAPI_MESSAGE_CHANNEL_H_
#define WEBKIT_PLUGINS_PPAPI_MESSAGE_CHANNEL_H_
+#include "base/task.h"
#include "third_party/npapi/bindings/npruntime.h"
#include "webkit/plugins/ppapi/resource.h"
@@ -44,7 +45,11 @@
explicit MessageChannel(PluginInstance* instance);
~MessageChannel();
+ // Post a message to the onmessage handler for this channel's instance
+ // asynchronously.
void PostMessageToJavaScript(PP_Var message_data);
+ // Post a message to the PPP_Instance HandleMessage function for this
+ // channel's instance.
void PostMessageToNative(PP_Var message_data);
// Return the NPObject* to which we should forward any calls which aren't
@@ -81,8 +86,21 @@
// to a JavaScript target.
NPVariant onmessage_invoker_;
+ // Evaluates the JavaScript code for onmessage_invoker_ and makes
+ // it a callable NPVariant for that function. Returns true on success, false
+ // otherwise.
bool EvaluateOnMessageInvoker();
+ // Post a message to the onmessage handler for this channel's instance
+ // synchronously. This is used by PostMessageToJavaScript.
+ void PostMessageToJavaScriptImpl(PP_Var message_data);
+ // Post a message to the PPP_Instance HandleMessage function for this
+ // channel's instance. This is used by PostMessageToNative.
+ void PostMessageToNativeImpl(PP_Var message_data);
+
+ // Ensure pending tasks will not fire after this object is destroyed.
+ ScopedRunnableMethodFactory<MessageChannel> method_factory_;
+
DISALLOW_COPY_AND_ASSIGN(MessageChannel);
};
« no previous file with comments | « ppapi/tests/test_post_message.cc ('k') | webkit/plugins/ppapi/message_channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698