Add binary-op stub variant to handle oddball objects more efficiently.

src/arm/code-stubs-arm.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2866 matching lines @@
       break;
     case TRBinaryOpIC::SMI:
       GenerateSmiStub(masm);
       break;
     case TRBinaryOpIC::INT32:
       GenerateInt32Stub(masm);
       break;
     case TRBinaryOpIC::HEAP_NUMBER:
       GenerateHeapNumberStub(masm);
       break;
+    case TRBinaryOpIC::ODDBALL:
+      GenerateOddballStub(masm);
+      break;
     case TRBinaryOpIC::STRING:
       GenerateStringStub(masm);
       break;
     case TRBinaryOpIC::GENERIC:
       GenerateGeneric(masm);
       break;
     default:
       UNREACHABLE();
   }
 }
@@ skipping 702 matching lines @@
   if (transition.is_linked()) {
     __ bind(&transition);
     GenerateTypeTransition(masm);
   }
 
   __ bind(&call_runtime);
   GenerateCallRuntime(masm);
 }
 
 
+void TypeRecordingBinaryOpStub::GenerateOddballStub(MacroAssembler* masm) {
+  Label call_runtime;
+
+  if (op_ == Token::ADD) {
+    // Handle string addition here, because it is the only operation
+    // that does not do a ToNumber conversion on the operands.
+    GenerateAddStrings(masm);
+  }
+
+  // Convert odd ball arguments to numbers.

[Erik Corry, 2011/03/28 15:15:24]

odd ball -> oddball

[fschneider, 2011/03/28 16:28:59]

Done.

+  Label check, done;
+  __ cmp(r1, Operand(FACTORY->undefined_value()));

[Erik Corry, 2011/03/28 15:15:24]

You should use CompareRoot here.

[fschneider, 2011/03/28 16:28:59]

Done.

+  __ b(ne, &check);
+  if (Token::IsBitOp(op_)) {
+    __ mov(r1, Operand(Smi::FromInt(0)));
+  } else {
+    __ Move(r1, FACTORY->nan_value());

[Erik Corry, 2011/03/28 15:15:24]

LoadRoot.

[fschneider, 2011/03/28 16:28:59]

Done.

+  }
+  __ jmp(&done);
+  __ bind(&check);
+  __ cmp(r0, Operand(FACTORY->undefined_value()));
+  __ b(ne, &done);
+  if (Token::IsBitOp(op_)) {
+    __ mov(r0, Operand(Smi::FromInt(0)));
+  } else {
+    __ Move(r0, FACTORY->nan_value());

[Erik Corry, 2011/03/28 15:15:24]

LoadRoot

[fschneider, 2011/03/28 16:28:59]

Done.

+  }
+  __ bind(&done);
+
+  GenerateHeapNumberStub(masm);
+}
+
+
 void TypeRecordingBinaryOpStub::GenerateHeapNumberStub(MacroAssembler* masm) {
   Label call_runtime;
   ASSERT(operands_type_ == TRBinaryOpIC::HEAP_NUMBER);
 
   GenerateFPOperation(masm, false, &call_runtime, &call_runtime);
 
   __ bind(&call_runtime);
   GenerateCallRuntime(masm);
 }
 
@@ skipping 3244 matching lines @@
   __ str(pc, MemOperand(sp, 0));
   __ Jump(target);  // Call the C++ function.
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_ARM