Add binary-op stub variant to handle oddball objects more efficiently.

Add binary-op stub variant to handle oddball objects more efficiently.
Committed: http://code.google.com/p/v8/source/detail?r=7396

[Erik Corry, 2011-03-25 14:15:13]

LGTM

http://codereview.chromium.org/6744006/diff/1/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/6744006/diff/1/src/ic.cc#newcode2199
src/ic.cc:2199: if (left->IsNumber() && right->IsUndefined()) return ODDBALL;
How about both are undefined?

[Erik Corry, 2011-03-25 14:21:17]

http://codereview.chromium.org/6744006/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

http://codereview.chromium.org/6744006/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:2029: GenerateAddStrings(masm);
Please add comment that we need this because add is the only one that does not
do TONUMBER.

[fschneider, 2011-03-28 08:00:54]

Added x64 and ARM code.

Please review!

http://codereview.chromium.org/6744006/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

http://codereview.chromium.org/6744006/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:2029: GenerateAddStrings(masm);
On 2011/03/25 14:21:18, Erik Corry wrote:
> Please add comment that we need this because add is the only one that does not
> do TONUMBER.

Done.

http://codereview.chromium.org/6744006/diff/1/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/6744006/diff/1/src/ic.cc#newcode2199
src/ic.cc:2199: if (left->IsNumber() && right->IsUndefined()) return ODDBALL;
On 2011/03/25 14:15:13, Erik Corry wrote:
> How about both are undefined?

Done.

[Erik Corry, 2011-03-28 15:15:24]

LGTM

http://codereview.chromium.org/6744006/diff/5001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/6744006/diff/5001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:3621: // Convert odd ball arguments to numbers.
odd ball -> oddball

http://codereview.chromium.org/6744006/diff/5001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:3623: __ cmp(r1, Operand(FACTORY->undefined_value()));
You should use CompareRoot here.

http://codereview.chromium.org/6744006/diff/5001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:3628: __ Move(r1, FACTORY->nan_value());
LoadRoot.

http://codereview.chromium.org/6744006/diff/5001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:3637: __ Move(r0, FACTORY->nan_value());
LoadRoot

http://codereview.chromium.org/6744006/diff/5001/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/6744006/diff/5001/src/ic.cc#newcode2200
src/ic.cc:2200: if (left->IsUndefined() && right->IsUndefined()) return ODDBALL;
The ARM code can't actually handle this case.

http://codereview.chromium.org/6744006/diff/5001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

http://codereview.chromium.org/6744006/diff/5001/src/x64/code-stubs-x64.cc#ne...
src/x64/code-stubs-x64.cc:1455: __ Cmp(rdx, FACTORY->undefined_value());
CompareRoot and LoadRoot.

[fschneider, 2011-03-28 16:28:59]

http://codereview.chromium.org/6744006/diff/5001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/6744006/diff/5001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:3621: // Convert odd ball arguments to numbers.
On 2011/03/28 15:15:24, Erik Corry wrote:
> odd ball -> oddball

Done.

http://codereview.chromium.org/6744006/diff/5001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:3623: __ cmp(r1, Operand(FACTORY->undefined_value()));
On 2011/03/28 15:15:24, Erik Corry wrote:
> You should use CompareRoot here.

Done.

http://codereview.chromium.org/6744006/diff/5001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:3628: __ Move(r1, FACTORY->nan_value());
On 2011/03/28 15:15:24, Erik Corry wrote:
> LoadRoot.

Done.

http://codereview.chromium.org/6744006/diff/5001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:3637: __ Move(r0, FACTORY->nan_value());
On 2011/03/28 15:15:24, Erik Corry wrote:
> LoadRoot

Done.

http://codereview.chromium.org/6744006/diff/5001/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/6744006/diff/5001/src/ic.cc#newcode2200
src/ic.cc:2200: if (left->IsUndefined() && right->IsUndefined()) return ODDBALL;
On 2011/03/28 15:15:24, Erik Corry wrote:
> The ARM code can't actually handle this case.

Done.

http://codereview.chromium.org/6744006/diff/5001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

http://codereview.chromium.org/6744006/diff/5001/src/x64/code-stubs-x64.cc#ne...
src/x64/code-stubs-x64.cc:1455: __ Cmp(rdx, FACTORY->undefined_value());
On 2011/03/28 15:15:24, Erik Corry wrote:
> CompareRoot and LoadRoot.

Done.