Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 6740023: Fix SlotRef::SlotAddress for parameters indices. (Closed)

Created:
9 years, 8 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix SlotRef::SlotAddress for parameters indices. Fix %NewObjectFromBound to correctly handle optimized frames (including those with inlined functions). Fix %_IsConstructCall handling in hydrogen: when called from inlined function return false constant directly instead of emiting HIsConstructCall. Fix success case in TraceInline. BUG=v8:1229 TEST=test/mjsunit/regress/regress-1229.js

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -188 lines) Patch
M src/accessors.cc View 2 chunks +3 lines, -167 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +72 lines, -0 lines 1 comment Download
M src/deoptimizer.cc View 1 chunk +99 lines, -0 lines 0 comments Download
M src/hydrogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +17 lines, -4 lines 0 comments Download
M src/runtime.cc View 2 chunks +45 lines, -17 lines 0 comments Download
A test/mjsunit/regress/regress-1229.js View 1 chunk +79 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
9 years, 8 months ago (2011-03-31 15:37:29 UTC) #1
Kevin Millikin (Chromium)
9 years, 8 months ago (2011-04-01 08:53:16 UTC) #2
LGTM.

http://codereview.chromium.org/6740023/diff/1/src/deoptimizer.h
File src/deoptimizer.h (right):

http://codereview.chromium.org/6740023/diff/1/src/deoptimizer.h#newcode616
src/deoptimizer.h:616: const int offset =
JavaScriptFrameConstants::kSavedRegistersOffset;
kSavedRegistersOffset is an archaic name.  Maybe it's time to change it to
something like kLastParameterOffset.

Powered by Google App Engine
This is Rietveld 408576698