Issue 6740019: Remove counters from generated isolate-independent MemCopy on ia32 platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6740019: Remove counters from generated isolate-independent MemCopy on ia32 platform. (Closed)

Created:
9 years, 8 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
fschneider, Vitaly Repeshko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Remove counters from generated isolate-independent MemCopy on ia32 platform. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7457

Patch Set 1 #

Patch Set 2 : remove tabs #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -14 lines)			Patch
	M	src/ia32/codegen-ia32.cc	View	1	5 chunks	+9 lines, -11 lines	0 comments	Download
	M	src/v8-counters.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

Will this fix it, or is there a fundamental reason why we need isolate-dependent copies. ...

9 years, 8 months ago (2011-03-31 08:24:24 UTC) #1

Vitaly Repeshko

9 years, 8 months ago (2011-03-31 11:14:00 UTC) #3

LGTM.

This is an improvement, but still depends on isolate because of the CPU features
and handle scope. In one case it's actually called from NoHandleAllocation and
messes things up. I'll fix the CPU features today.


Thanks,
Vitaly

Expand Messages | Collapse Messages