Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 6740015: Adds the first bits of our disks daemon. (Closed)

Created:
9 years, 8 months ago by rtc
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Basically a skeleton binary and build file. BUG=chromium-os:13698 TEST=everything builds and runs. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f715e6d

Patch Set 1 #

Patch Set 2 : fixes copyright dates #

Total comments: 1

Patch Set 3 : line wraps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+540 lines, --1 lines) Patch
A .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
A Makefile View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A common.mk View 1 1 chunk +478 lines, -0 lines 0 comments Download
A inherit-review-settings-ok View 0 chunks +-1 lines, --1 lines 0 comments Download
A main.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rtc
9 years, 8 months ago (2011-03-31 05:29:31 UTC) #1
Chris Masone
9 years, 8 months ago (2011-03-31 14:48:18 UTC) #2
LGTM w/nit

http://codereview.chromium.org/6740015/diff/3001/Makefile
File Makefile (right):

http://codereview.chromium.org/6740015/diff/3001/Makefile#newcode14
Makefile:14: INCLUDE_DIRS = -I.. $(shell $(PKG_CONFIG) --cflags dbus-1
dbus-glib-1 dbus-c++-1 glib-2.0)
do we do 80char in makefiles?

Powered by Google App Engine
This is Rietveld 408576698