Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 6738002: CHROMIUMOS: dhcp: Remove errant extra ref (Closed)

Created:
9 years, 9 months ago by Paul Stewart
Modified:
9 years, 7 months ago
Reviewers:
Sam Leffler
CC:
chromium-os-reviews_chromium.org, pskishore_google.com
Visibility:
Public.

Description

CHROMIUMOS: dhcp: Remove errant extra ref In the utility function get_option, a buffer is allocated and returned if there is more than one instance of the desired option in the dhcp message. Unfortunately this code has never worked (fixed somewhere upstream). It used to return the address of the buf pointer instead of the buffer itself. This solves issues with DHCP servers with surprising (but perhaps valid) duplicate messages in their response. BUG=n0ne TEST=Aruba RAP-5WN Change-Id: Iaa648cc2b602c670d2c331edd64374ccbe4d0bde R=sleffler@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=6e658ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M dhcp.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Stewart
9 years, 9 months ago (2011-03-25 09:59:24 UTC) #1
Sam Leffler
9 years, 9 months ago (2011-03-25 20:25:11 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698