Proxy settings automation hooks and related proxy settings fixes.

chrome/browser/resources/options/chromeos_proxy.html

Index: chrome/browser/resources/options/chromeos_proxy.html
diff --git a/chrome/browser/resources/options/chromeos_proxy.html b/chrome/browser/resources/options/chromeos_proxy.html
index ae9efe521e0f998e914aad24fa7f0e88a861d6b2..81c3d1ee3eb7f89ed93c78edc4bd12112daf42bc 100644
--- a/chrome/browser/resources/options/chromeos_proxy.html
+++ b/chrome/browser/resources/options/chromeos_proxy.html
@@ -32,7 +32,7 @@
           </td><td>
           <span
             i18n-content="proxyPort"></span>
-          <input id="proxyHostSinglePort" type="text" size="5" pref="cros.session.proxy.singlehttpport" disabled>
+          <input id="proxyHostSinglePort" type="text" dataType="number" size="5" pref="cros.session.proxy.singlehttpport" disabled>

[xiyuan, 2011/04/04 21:24:20]

I don't think we need a new "dataType" attribute. If you need an integer, you
could change type="text" to type="number". That should bind to PrefNumber and
give you an integer back. And webkit would also validate user's input as well.

[dtu, 2011/04/04 22:48:57]

I tried type="number". Having the input validation is nice, and you can set min
and max values; however, using this element changes the UI in two ways that are
not preferable:
1. It adds up/down arrows into the box, which are not useful when entering a
port number.
2. When you take focus off the box, it automatically adds thousands separators,
e.g. 12345 becomes 12,345.
#2 is a bigger problem. I thought there might be some way to change the behavior
using CSS or JS but couldn't find any documentation on it since it is a new
HTML5 element and this seems to happen only in recent versions of Chrome.

[xiyuan, 2011/04/04 23:31:18]

Okay. In this case, I am okay with the new attribute approach.

           </td></tr>
         </table>
       </div>
@@ -45,7 +45,7 @@
         </td><td>
         <span
           i18n-content="proxyPort"></span></td><td>
-        <input id="proxyHostPort" type="text" size="5" pref="cros.session.proxy.httpport" disabled>
+        <input id="proxyHostPort" type="text" dataType="number" size="5" pref="cros.session.proxy.httpport" disabled>
         </td></tr>
         <tr>
         <td><span
@@ -54,7 +54,7 @@
         </td><td>
         <span
           i18n-content="proxyPort"></span></td><td>
-        <input id="secureProxyPort" type="text" size="5" pref="cros.session.proxy.httpsport" disabled>
+        <input id="secureProxyPort" type="text" dataType="number" size="5" pref="cros.session.proxy.httpsport" disabled>
         </td></tr>
         <tr>
         <td><span
@@ -63,7 +63,7 @@
           </td><td>
           <span
             i18n-content="proxyPort"></span></td><td>
-          <input id="ftpProxyPort" type="text" size="5" pref="cros.session.proxy.ftpport" disabled>
+          <input id="ftpProxyPort" type="text" dataType="number" size="5" pref="cros.session.proxy.ftpport" disabled>
         </td></tr>
         <tr>
         <td><span
@@ -72,7 +72,7 @@
           </td><td>
           <span
             i18n-content="proxyPort"></span></td><td>
-          <input id="socksPort" type="text" size="5" pref="cros.session.proxy.socksport" disabled>
+          <input id="socksPort" type="text" dataType="number" size="5" pref="cros.session.proxy.socksport" disabled>
         </td></tr>
         </table>
       </div>