Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 6737003: Removing unneeded TLS fetch from v8::Null and friends (Closed)

Created:
9 years, 9 months ago by Dmitry Lomov
Modified:
9 years, 7 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Removing unneeded TLS fetch from v8::Null and friends BUG= TEST=

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -48 lines) Patch
M src/api.cc View 3 chunks +18 lines, -43 lines 3 comments Download
M src/apiutils.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov
Removed extra TLS feteches in v8::{Null,Undefined,True,False}. Some tummy speedups in dom-query. I have inlined and ...
9 years, 9 months ago (2011-03-25 03:12:04 UTC) #1
Vitaly Repeshko
LGTM. I'll address my own comments and land. Thanks, Vitaly http://codereview.chromium.org/6737003/diff/1/src/api.cc File src/api.cc (left): http://codereview.chromium.org/6737003/diff/1/src/api.cc#oldcode318 ...
9 years, 9 months ago (2011-03-25 13:48:03 UTC) #2
Vitaly Repeshko
9 years, 9 months ago (2011-03-25 14:09:46 UTC) #3
Landed in r7374. Closing code review.


-- Vitaly

Powered by Google App Engine
This is Rietveld 408576698