Install test scripts into chroot.

Install test scripts into chroot.

This also removes support for all scripts that don't really work without a chroot
to only run inside a chroot.  This includes:

run_remote_tests
cros_run_vm_tests
parallel_run_vm_tests

Change-Id: I5c89466047047025de6c934b38ef6be8a23ea058

BUG=chromium-os:13498
TEST=Ran full x86-generic-pre-flight-queue with this CL patched in. CBuildbot / CBuild already have their test calls uses enter_chroot.sh -- before their test call.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=98c6a53

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9ff805c

[sosa, 2011-03-25 04:43:47]

Wanted to send this out for early feedback.

I think with this CL we want to remove support of running these scripts outside
the chroot that completely require a chroot to exist.  All of these scripts fall
into this category.

I'm open to changing the symlinks in src/scripts to something like ...
./enter_chroot.sh -- $* to allow ppl to still "call" them from outside the
chroot, though a PSA maybe all I need.

This is only partially done.  Just checking to see if you think it's ok to
remove support outside the chroot with advanced notice.  It'll make  this CL
much cleaner.

Also:  Ken as far as the bug with hang bug in run_remote_tests ...it looks like
this was already fixed in:  http://codereview.chromium.org/6368022/

http://codereview.chromium.org/6736023/diff/1/cros_run_vm_test
File cros_run_vm_test (left):

http://codereview.chromium.org/6736023/diff/1/cros_run_vm_test#oldcode75
cros_run_vm_test:75: if [ -n "${FLAGS_verify_chrome_version}" ]; then
No one uses this flag anymore.

http://codereview.chromium.org/6736023/diff/1/cros_run_vm_test
File cros_run_vm_test (right):

http://codereview.chromium.org/6736023/diff/1/cros_run_vm_test#newcode10
cros_run_vm_test:10: . "/usr/lib/crosutils/common.sh" 2> /dev/null ||
run_remote_tests can't run outside and we now have kvm support in chroot.

http://codereview.chromium.org/6736023/diff/1/run_remote_tests.sh
File run_remote_tests.sh (right):

http://codereview.chromium.org/6736023/diff/1/run_remote_tests.sh#newcode11
run_remote_tests.sh:11: . "/usr/lib/crosutils/remote_access.sh" || die "Unable
to load remote_access.sh"
There wasn't much point in leaving this here since down below we immediately ran
a restart_inside_chroot.

[sosa, 2011-03-30 01:09:42]

PTAL.  This CL is ready for full review

Tested with full run of x86-generic-pfq

http://codereview.chromium.org/6736023/diff/17001/cros_run_vm_test
File cros_run_vm_test (left):

http://codereview.chromium.org/6736023/diff/17001/cros_run_vm_test#oldcode75
cros_run_vm_test:75: if [ -n "${FLAGS_verify_chrome_version}" ]; then
No one uses this

[sosa, 2011-03-30 01:11:18]

Also +cc dale as an FYI

[petkov, 2011-03-30 14:32:15]

Mostly nits...

http://codereview.chromium.org/6736023/diff/17001/Makefile
File Makefile (right):

http://codereview.chromium.org/6736023/diff/17001/Makefile#newcode18
Makefile:18: install -m 0644 unit_test_black_list.txt
"${DESTDIR}/usr/share/crostestutils"
80 chars

http://codereview.chromium.org/6736023/diff/17001/Makefile#newcode24
Makefile:24: # Make symlink for those python files in lib.
symlinks

http://codereview.chromium.org/6736023/diff/17001/cros_run_vm_test
File cros_run_vm_test (right):

http://codereview.chromium.org/6736023/diff/17001/cros_run_vm_test#newcode10
cros_run_vm_test:10: . "/usr/lib/crosutils/common.sh" 2> /dev/null ||
msb changed this in a few places to just source common.sh || exit 1. this seems
to be enough because you get an error message from bash anyway. and it's a one
liner.

http://codereview.chromium.org/6736023/diff/17001/cros_run_vm_test#newcode13
cros_run_vm_test:13: . "/usr/lib/crosutils/lib/cros_vm_lib.sh" || die "Unable to
load cros_vm_lib.sh"
it might be worth defining CROSUTILS and using it throughout.

http://codereview.chromium.org/6736023/diff/17001/cros_run_vm_test#newcode14
cros_run_vm_test:14: . "/usr/lib/crosutils/lib/cros_vm_constants.sh" || \
no need for trailing \

http://codereview.chromium.org/6736023/diff/17001/cros_run_vm_test#newcode72
cros_run_vm_test:72: run_remote_tests.sh \
you're relying on crosutils to be on the path? why don't you do the same for
get_latest_image.sh above too?

http://codereview.chromium.org/6736023/diff/17001/utils_py/cros_run_parallel_...
File utils_py/cros_run_parallel_vm_tests.py (right):

http://codereview.chromium.org/6736023/diff/17001/utils_py/cros_run_parallel_...
utils_py/cros_run_parallel_vm_tests.py:74: args = [ 'cros_run_vm_test',
I assume Popen below does a path lookup?

[sosa, 2011-03-30 18:35:50]

PTAL

http://codereview.chromium.org/6736023/diff/17001/Makefile
File Makefile (right):

http://codereview.chromium.org/6736023/diff/17001/Makefile#newcode18
Makefile:18: install -m 0644 unit_test_black_list.txt
"${DESTDIR}/usr/share/crostestutils"
On 2011/03/30 14:32:16, petkov wrote:
> 80 chars

Done.

http://codereview.chromium.org/6736023/diff/17001/Makefile#newcode24
Makefile:24: # Make symlink for those python files in lib.
On 2011/03/30 14:32:16, petkov wrote:
> symlinks

Done.

http://codereview.chromium.org/6736023/diff/17001/cros_run_vm_test
File cros_run_vm_test (right):

http://codereview.chromium.org/6736023/diff/17001/cros_run_vm_test#newcode10
cros_run_vm_test:10: . "/usr/lib/crosutils/common.sh" 2> /dev/null ||
On 2011/03/30 14:32:16, petkov wrote:
> msb changed this in a few places to just source common.sh || exit 1. this
seems
> to be enough because you get an error message from bash anyway. and it's a one
> liner.

Done.

http://codereview.chromium.org/6736023/diff/17001/cros_run_vm_test#newcode13
cros_run_vm_test:13: . "/usr/lib/crosutils/lib/cros_vm_lib.sh" || die "Unable to
load cros_vm_lib.sh"
On 2011/03/30 14:32:16, petkov wrote:
> it might be worth defining CROSUTILS and using it throughout.

Done.

http://codereview.chromium.org/6736023/diff/17001/cros_run_vm_test#newcode14
cros_run_vm_test:14: . "/usr/lib/crosutils/lib/cros_vm_constants.sh" || \
On 2011/03/30 14:32:16, petkov wrote:
> no need for trailing \

Done.

http://codereview.chromium.org/6736023/diff/17001/cros_run_vm_test#newcode72
cros_run_vm_test:72: run_remote_tests.sh \
All scripts (non-symlinks) in src/scripts are installed in /usr/lib/crosutils
... first-order bin's are installed in /usr/bin.  run_remote_tests is managed by
this package and installed by the Makefile in /usr/bin

On 2011/03/30 14:32:16, petkov wrote:
> you're relying on crosutils to be on the path? why don't you do the same for
> get_latest_image.sh above too?

http://codereview.chromium.org/6736023/diff/17001/utils_py/cros_run_parallel_...
File utils_py/cros_run_parallel_vm_tests.py (right):

http://codereview.chromium.org/6736023/diff/17001/utils_py/cros_run_parallel_...
utils_py/cros_run_parallel_vm_tests.py:74: args = [ 'cros_run_vm_test',
Yes. Re-verified it.

On 2011/03/30 14:32:16, petkov wrote:
> I assume Popen below does a path lookup?

[petkov, 2011-03-30 18:54:10]

LGTM

[sosa, 2011-03-31 20:43:40]

Please review patches 9,10.  Disabled support for running VM's outside chroot
and made it clear when you run a vm script inside chroot that it shouldn't be
run there.

Also cleaned up some path issues in the au test harness so it can be run from
any dir.

[petkov, 2011-03-31 23:29:08]

LGTM