Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: base/debug/debug_on_start_win.h

Issue 6736019: Base: A few more files using BASE_API (for base.dll) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/debug/debugger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/debug_on_start_win.h
===================================================================
--- base/debug/debug_on_start_win.h (revision 79303)
+++ base/debug/debug_on_start_win.h (working copy)
@@ -24,6 +24,11 @@
namespace base {
namespace debug {
+// There is no way for this code, as currently implemented, to work across DLLs.
+// TODO(rvargas): It looks like we really don't use this code, at least not for
+// Chrome. Figure out if it's really worth implementing something simpler.
+#if !defined(BASE_DLL)
+
// Debug on start functions and data.
class DebugOnStart {
public:
@@ -69,6 +74,8 @@
#endif // _WIN64
+#endif // defined(BASE_DLL)
+
} // namespace debug
} // namespace base
« no previous file with comments | « no previous file | base/debug/debugger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698