improve logging slightly

presubmit_support.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Enables directory-specific presubmit checks to run at upload and/or commit.
 """
 
 __version__ = '1.4'
 
@@ skipping 1022 matching lines @@
 
   Warning:
     If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
     SHOULD be sys.stdin.
 
   Return:
     A PresubmitOutput object. Use output.should_continue() to figure out
     if there were errors or warnings and the caller should abort.
   """
   output = PresubmitOutput(input_stream, output_stream)
-  output.write("Running presubmit hooks...\n")
+  if committing:
+    output.write("Running presubmit commit checks ...\n")
+  else:
+    output.write("Running presubmit upload checks ...\n")
   start_time = time.time()
   presubmit_files = ListRelevantPresubmitFiles(change.AbsoluteLocalPaths(True),
                                                change.RepositoryRoot())
   if not presubmit_files and verbose:
     output.write("Warning, no presubmit.py found.\n")
   results = []
   executer = PresubmitExecuter(change, committing, tbr, host_url)
   if default_presubmit:
     if verbose:
       output.write("Running default presubmit script.\n")
@@ skipping 11 matching lines @@
   notifications = []
   warnings = []
   for result in results:
     if result.fatal:
       errors.append(result)
     elif result.should_prompt:
       warnings.append(result)
     else:
       notifications.append(result)
 
+  output.write('\n')
   for name, items in (('Messages', notifications),
                       ('Warnings', warnings),
                       ('ERRORS', errors)):
     if items:
       output.write('** Presubmit %s **\n' % name)
       for item in items:
         item.handle(output)
         output.write('\n')
 
   total_time = time.time() - start_time
   if total_time > 1.0:
-    output.write("Presubmit checks took %.1fs to calculate.\n" % total_time)
+    output.write("Presubmit checks took %.1fs to calculate.\n\n" % total_time)
 
-  if not errors and warnings:
-    if may_prompt:
+  if not errors:
+    if not warnings:
+      output.write('Presubmit checks passed.\n')
+    elif may_prompt:
       output.prompt_yes_no('There were presubmit warnings. '
                           'Are you sure you wish to continue? (y/N): ')
     else:
       output.fail()
 
   global _ASKED_FOR_FEEDBACK
   # Ask for feedback one time out of 5.
   if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
     output.write("Was the presubmit check useful? Please send feedback "
                  "& hate mail to maruel@chromium.org!\n")
@@ skipping 89 matching lines @@
                               sys.stdout,
                               sys.stdin,
                               options.default_presubmit,
                               options.may_prompt)
   return not results.should_continue()
 
 
 if __name__ == '__main__':
   fix_encoding.fix_encoding()
   sys.exit(Main(None))