Issue 6735060: NSColor* and NSSize BS in profile_menu_button.mm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6735060: NSColor* and NSSize BS in profile_menu_button.mm (Closed)

Created:
9 years, 8 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
sail

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

NSColor* and NSSize arguments are a problem with receivers held by scoped_nsobject<> when using the 10.6 SDK. TEST=Compile with 10.6 SDK BUG=35569, 35578 (sort of) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80481

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	chrome/browser/ui/cocoa/profile_menu_button.mm	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sail

LGTM Argh, will watch out for this in the future. Thanks for fixing it.

9 years, 8 months ago (2011-04-05 16:58:26 UTC) #2

Mark Mentovai

9 years, 8 months ago (2011-04-05 16:59:47 UTC) #3

It might be worth someone’s while (mine included) to figure out why this is a
problem in the 10.6 SDK, since it comes up once a month or so. We may be able to
come up with something better than this workaround.

Expand Messages | Collapse Messages