Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Unified Diff: chrome/browser/chromeos/wm_overview_controller.cc

Issue 6735042: Move favicon from TabContents to TabContentsWrapper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/wm_overview_controller.cc
diff --git a/chrome/browser/chromeos/wm_overview_controller.cc b/chrome/browser/chromeos/wm_overview_controller.cc
index 2914fb3fe1c1ce4dd1862538dd38b9a04897d116..11807ab77d109a950460eb5fec6836708c862ca4 100644
--- a/chrome/browser/chromeos/wm_overview_controller.cc
+++ b/chrome/browser/chromeos/wm_overview_controller.cc
@@ -13,6 +13,7 @@
#include "chrome/browser/chromeos/wm_overview_favicon.h"
#include "chrome/browser/chromeos/wm_overview_snapshot.h"
#include "chrome/browser/chromeos/wm_overview_title.h"
+#include "chrome/browser/favicon_tab_helper.h"
#include "chrome/browser/tab_contents/thumbnail_generator.h"
#include "chrome/browser/tabs/tab_strip_model.h"
#include "chrome/browser/ui/browser.h"
@@ -239,7 +240,7 @@ void BrowserListener::TabChangedAt(
snapshots_[index].title->SetTitle(contents->tab_contents()->GetTitle());
snapshots_[index].title->SetUrl(contents->tab_contents()->GetURL());
snapshots_[index].favicon->SetFavicon(
- contents->tab_contents()->GetFavicon());
+ contents->favicon_tab_helper()->GetFavicon());
if (change_type != TabStripModelObserver::TITLE_NOT_LOADING)
MarkSnapshotAsDirty(index);
}
@@ -424,7 +425,9 @@ void BrowserListener::InsertSnapshot(int index) {
node.favicon = new WmOverviewFavicon;
node.favicon->Init(node.snapshot);
- node.favicon->SetFavicon(browser_->GetTabContentsAt(index)->GetFavicon());
+ node.favicon->SetFavicon(
+ browser_->GetTabContentsWrapperAt(index)->
+ favicon_tab_helper()->GetFavicon());
node.title = new WmOverviewTitle;
node.title->Init(gfx::Size(std::max(0, cell_size.width() -
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_edit_unittest.cc ('k') | chrome/browser/content_setting_bubble_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698