Get rid of PrefService::GetMutableDictionary/GetMutableList

chrome/browser/ui/cocoa/window_size_autosaver_unittest.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #import "chrome/browser/ui/cocoa/window_size_autosaver.h"
 
 #include "base/memory/scoped_nsobject.h"
 #include "chrome/browser/prefs/pref_service.h"
+#include "chrome/browser/prefs/scoped_user_pref_update.h"
 #include "chrome/browser/ui/cocoa/browser_test_helper.h"
 #import "chrome/browser/ui/cocoa/cocoa_test_helper.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/platform_test.h"
 
 namespace {
 
 class WindowSizeAutosaverTest : public CocoaTest {
   virtual void SetUp() {
     CocoaTest::SetUp();
@@ skipping 67 matching lines @@
                   path:path_]);
     EXPECT_EQ(300, NSMinX([window_ frame]));
     EXPECT_EQ(310, NSMinY([window_ frame]));
     EXPECT_EQ(160, NSWidth([window_ frame]));
     EXPECT_EQ(162, NSHeight([window_ frame]));
   }
 
   // ...and it should be in the profile, too.
   EXPECT_TRUE(pref->GetDictionary(path_) != NULL);
   int x, y;
-  DictionaryValue* windowPref = pref->GetMutableDictionary(path_);
+  const DictionaryValue* windowPref = pref->GetDictionary(path_);
   EXPECT_FALSE(windowPref->GetInteger("left", &x));
   EXPECT_FALSE(windowPref->GetInteger("right", &x));
   EXPECT_FALSE(windowPref->GetInteger("top", &x));
   EXPECT_FALSE(windowPref->GetInteger("bottom", &x));
   ASSERT_TRUE(windowPref->GetInteger("x", &x));
   ASSERT_TRUE(windowPref->GetInteger("y", &y));
   EXPECT_EQ(300, x);
   EXPECT_EQ(310, y);
 }
 
@@ skipping 38 matching lines @@
                   path:path_]);
     EXPECT_EQ(300, NSMinX([window_ frame]));
     EXPECT_EQ(310, NSMinY([window_ frame]));
     EXPECT_EQ(250, NSWidth([window_ frame]));
     EXPECT_EQ(252, NSHeight([window_ frame]));
   }
 
   // ...and it should be in the profile, too.
   EXPECT_TRUE(pref->GetDictionary(path_) != NULL);
   int x1, y1, x2, y2;
-  DictionaryValue* windowPref = pref->GetMutableDictionary(path_);
+  const DictionaryValue* windowPref = pref->GetDictionary(path_);
   EXPECT_FALSE(windowPref->GetInteger("x", &x1));
   EXPECT_FALSE(windowPref->GetInteger("y", &x1));
   ASSERT_TRUE(windowPref->GetInteger("left", &x1));
   ASSERT_TRUE(windowPref->GetInteger("right", &x2));
   ASSERT_TRUE(windowPref->GetInteger("top", &y1));
   ASSERT_TRUE(windowPref->GetInteger("bottom", &y2));
   EXPECT_EQ(300, x1);
   EXPECT_EQ(310, y1);
   EXPECT_EQ(300 + 250, x2);
   EXPECT_EQ(310 + 252, y2);
 }
 
 // http://crbug.com/39625
 TEST_F(WindowSizeAutosaverTest, DoesNotRestoreButClearsEmptyRect) {
   PrefService* pref = browser_helper_.profile()->GetPrefs();
   ASSERT_TRUE(pref != NULL);
 
-  DictionaryValue* windowPref = pref->GetMutableDictionary(path_);
+  DictionaryPrefUpdate update(pref, path_);
+  DictionaryValue* windowPref = update.Get();
   windowPref->SetInteger("left", 50);
   windowPref->SetInteger("right", 50);
   windowPref->SetInteger("top", 60);
   windowPref->SetInteger("bottom", 60);
 
   {
     // Window rect shouldn't change...
     NSRect frame = [window_ frame];
     scoped_nsobject<WindowSizeAutosaver> sizeSaver([[WindowSizeAutosaver alloc]
         initWithWindow:window_
@@ skipping 10 matching lines @@
   int x1, y1, x2, y2;
   EXPECT_FALSE(windowPref->GetInteger("x", &x1));
   EXPECT_FALSE(windowPref->GetInteger("y", &x1));
   ASSERT_FALSE(windowPref->GetInteger("left", &x1));
   ASSERT_FALSE(windowPref->GetInteger("right", &x2));
   ASSERT_FALSE(windowPref->GetInteger("top", &y1));
   ASSERT_FALSE(windowPref->GetInteger("bottom", &y2));
 }
 
 }  // namespace