Issue 6735032: Get rid of PrefService::GetMutableDictionary/GetMutableList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6735032: Get rid of PrefService::GetMutableDictionary/GetMutableList (Closed)

Created:
9 years, 8 months ago by battre

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Get rid of PrefService::GetMutableDictionary/GetMutableList BUG=77914 TEST=none, trybots remain green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80475

Patch Set 1 #

Patch Set 2 : Updated license header #

Total comments: 1

Patch Set 3 : Addressed comment #

Patch Set 4 : Fixed function name #

Patch Set 5 : Added missing include #

Patch Set 6 : Fixed Mac compile error #

Patch Set 7 : Another windows compile error #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -25 lines)			Patch
M	chrome/browser/debugger/devtools_window.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller_private.mm	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/window_size_autosaver.mm	View	1 2 3 4 5	5 chunks	+11 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/cocoa/window_size_autosaver_unittest.mm	View		4 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/task_manager_gtk.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/chrome_views_delegate.cc	View	1 2 3	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/task_manager_view.cc	View	1 2 3 4 5 6	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

battre

Hi. May I ask you to review this? It is basically a list of several ...

9 years, 8 months ago (2011-04-04 17:10:50 UTC) #1

viettrungluu

9 years, 8 months ago (2011-04-04 20:44:09 UTC) #2

LGTM with one change you might want to make. Thanks for doing this.

http://codereview.chromium.org/6735032/diff/2001/chrome/browser/ui/cocoa/wind...
File chrome/browser/ui/cocoa/window_size_autosaver.mm (right):

http://codereview.chromium.org/6735032/diff/2001/chrome/browser/ui/cocoa/wind...
chrome/browser/ui/cocoa/window_size_autosaver.mm:88: // Windows should never be
very small.
Maybe the DictionaryPrefUpdate should only be used for this case?

Expand Messages | Collapse Messages