Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 6735029: gcl delete <non-existent change> won't throw an exception anymore (Closed)

Created:
9 years, 8 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

gcl delete <non-existent change> won't throw an exception anymore R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80337

Patch Set 1 #

Patch Set 2 : better error message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M gcl.py View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
9 years, 8 months ago (2011-04-04 14:56:55 UTC) #1
Dirk Pranke
9 years, 8 months ago (2011-04-04 17:28:30 UTC) #2
LGTM. 

Maybe add a test if it's not too much work?

Powered by Google App Engine
This is Rietveld 408576698