Issue 6735026: Remove chromeos_keyboard*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6735026: Remove chromeos_keyboard* (Closed)

Created:
9 years, 8 months ago by satorux1

Modified:
9 years, 7 months ago

Reviewers:
Yusuke Sato

CC:
chromium-os-reviews_chromium.org, DaveMoore

Base URL:
http://git.chromium.org/git/cros.git@master

Visibility:
Public.

Description

Remove chromeos_keyboard* We no longer use these files. BUG=chromium-os:12971, chromium-os:13106 TEST=keyboard switching worked as before. Change-Id: I7d31a4c5bfcbbebc23a5c3faee539eb503495f20 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=24a9714

Patch Set 1 #

Patch Set 2 : re-upload #

Patch Set 3 : re-upload #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -710 lines)			Patch
M	SConstruct.chromiumos	View	1 2	2 chunks	+1 line, -4 lines	0 comments	Download
M	chromeos_cros_api.h	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
D	chromeos_keyboard.h	View		1 chunk	+0 lines, -106 lines	0 comments	Download
D	chromeos_keyboard.cc	View		1 chunk	+0 lines, -377 lines	0 comments	Download
D	chromeos_keyboard_unittest.cc	View		1 chunk	+0 lines, -221 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

9 years, 8 months ago (2011-04-04 07:45:55 UTC) #2

LGTM.

Please remove x11-apps/setxkbmap from
chromiumos-overlay/chromeos-base/libcros/libcros-9999.ebuild and add it to
chromeos-base/chromeos-chrome/.




On 2011/04/04 07:36:53, satorux1 wrote:

Expand Messages | Collapse Messages