Coverity: Pass parameters by reference.

chrome/browser/browser_signin.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_signin.h"
 
 #include <string>
 #include <vector>
 
 #include "base/json/json_reader.h"
@@ skipping 59 matching lines @@
   scoped_refptr<RefCountedBytes> html_bytes(new RefCountedBytes);
   html_bytes->data.resize(response.size());
   std::copy(response.begin(), response.end(), html_bytes->data.begin());
   SendResponse(request_id, html_bytes);
 }
 
 class BrowserSigninHtml : public HtmlDialogUIDelegate,
                           public WebUIMessageHandler {
  public:
   BrowserSigninHtml(BrowserSignin* signin,
-                    string16 suggested_email,
-                    string16 login_message);
+                    const string16& suggested_email,
+                    const string16& login_message);
   virtual ~BrowserSigninHtml() {}
 
   // HtmlDialogUIDelegate implementation
   virtual bool IsDialogModal() const {
     return false;
   };
   virtual std::wstring GetDialogTitle() const {
     return L"";
   }
   virtual GURL GetDialogContentURL() const {
@@ skipping 36 matching lines @@
   // Nonowned pointer; |signin_| owns this object.
   BrowserSignin* signin_;
 
   string16 suggested_email_;
   string16 login_message_;
 
   bool closed_;
 };
 
 BrowserSigninHtml::BrowserSigninHtml(BrowserSignin* signin,
-                                     string16 suggested_email,
-                                     string16 login_message)
+                                     const string16& suggested_email,
+                                     const string16& login_message)
     : signin_(signin),
       suggested_email_(suggested_email),
       login_message_(login_message),
       closed_(false) {
 }
 
 void BrowserSigninHtml::RegisterMessages() {
   web_ui_->RegisterMessageCallback(
       "SubmitAuth", NewCallback(this, &BrowserSigninHtml::HandleSubmitAuth));
   web_ui_->RegisterMessageCallback(
@@ skipping 176 matching lines @@
 
 void BrowserSignin::ShowSigninTabModal(TabContents* tab_contents) {
 //  TODO(johnnyg): Need a linux views implementation for ConstrainedHtmlDialog.
 #if defined(OS_WIN) || defined(OS_CHROMEOS) || !defined(TOOLKIT_VIEWS)
   html_dialog_ui_delegate_ = CreateHtmlDialogUI();
   ConstrainedHtmlUI::CreateConstrainedHtmlDialog(profile_,
                                                  html_dialog_ui_delegate_,
                                                  tab_contents);
 #endif
 }