chrome/renderer/print_web_view_helper_linux.cc - Issue 6733036: Make PluginInstance::PrintPDFOutput-metafile implementation agnostic on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/print_web_view_helper_linux.cc

Issue 6733036: Make PluginInstance::PrintPDFOutput-metafile implementation agnostic on Linux. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix unref of potentially NULL object pointed out by thestig@. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/print_web_view_helper_linux.cc

diff --git a/chrome/renderer/print_web_view_helper_linux.cc b/chrome/renderer/print_web_view_helper_linux.cc

index 65370c7ca99004f06ded44fd6829f0c7dd32192c..98a2f803515fb80f077fb22a352b590c21e8e905 100644

--- a/chrome/renderer/print_web_view_helper_linux.cc

+++ b/chrome/renderer/print_web_view_helper_linux.cc

@@ -10,6 +10,7 @@

#include "chrome/common/print_messages.h"

#include "content/common/view_messages.h"

#include "printing/native_metafile_factory.h"

+#include "printing/native_metafile_skia_wrapper.h"

#include "printing/native_metafile.h"

#include "skia/ext/vector_canvas.h"

#include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"

@@ -228,6 +229,8 @@ void PrintWebViewHelper::PrintPage(const PrintMsg_PrintPage_Params& params,

return;

canvas->reset(new skia::VectorCanvas(device));

+ printing::NativeMetafileSkiaWrapper::SetMetafileOnCanvas(canvas->get(),

+ metafile);

frame->printPage(params.page_number, canvas->get());

// TODO(myhuang): We should handle transformation for paper margins.

« no previous file with comments | « no previous file | printing/native_metafile_skia_wrapper.h » ('j') | printing/native_metafile_skia_wrapper.cc » ('J')