Make PluginInstance::PrintPDFOutput-metafile implementation agnostic on Linux.

Make PluginInstance::PrintPDFOutput metafile-implementation agnostic on Linux.

PluginInstance::PrintPDFOutput wants to set the PDF bits in the metafile. This change makes it agnostic to the implementation of NativeMetafile in use by using the SkRefDict in SkDevice (and removes the old mechanism).

BUG=NONE
TEST=NONE

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79412

[Lei Zhang, 2011-03-24 21:28:27]

http://codereview.chromium.org/6733036/diff/1/printing/native_metafile_skia_w...
File printing/native_metafile_skia_wrapper.cc (right):

http://codereview.chromium.org/6733036/diff/1/printing/native_metafile_skia_w...
printing/native_metafile_skia_wrapper.cc:32: if (metafile)
What happens if |metafile| is NULL? Do we need this check?

http://codereview.chromium.org/6733036/diff/1/printing/native_metafile_skia_w...
File printing/native_metafile_skia_wrapper.h (right):

http://codereview.chromium.org/6733036/diff/1/printing/native_metafile_skia_w...
printing/native_metafile_skia_wrapper.h:29: static const char*
kNativeMetafileKey;
Can't you just remove it here and instead put it in the anonymous namespace in
native_metafile_skia_wrapper.cc?

http://codereview.chromium.org/6733036/diff/1/printing/native_metafile_skia_w...
printing/native_metafile_skia_wrapper.h:31: explicit
NativeMetafileSkiaWrapper(NativeMetafile* metafile);
nit: this goes before the member variables.

[kmadhusu, 2011-03-24 21:38:15]

http://codereview.chromium.org/6733036/diff/1/printing/printing.gyp
File printing/printing.gyp (right):

http://codereview.chromium.org/6733036/diff/1/printing/printing.gyp#newcode42
printing/printing.gyp:42: 'native_metafile_skia_wrapper.h',
style nit: Include them after "native_metafile.h".

[vandebo (ex-Chrome), 2011-03-24 21:44:45]

http://codereview.chromium.org/6733036/diff/1/printing/native_metafile_skia_w...
File printing/native_metafile_skia_wrapper.cc (right):

http://codereview.chromium.org/6733036/diff/1/printing/native_metafile_skia_w...
printing/native_metafile_skia_wrapper.cc:32: if (metafile)
On 2011/03/24 21:28:27, Lei Zhang wrote:
> What happens if |metafile| is NULL? Do we need this check?

There's no reason to store an entry in the SkRefDict if the value is NULL
(that's the value that will get returned anyway).  And setting a key to NULL in
the SkRefDict deletes any existing entry.  I only caught this myself on a second
read through of the change.

http://codereview.chromium.org/6733036/diff/1/printing/native_metafile_skia_w...
File printing/native_metafile_skia_wrapper.h (right):

http://codereview.chromium.org/6733036/diff/1/printing/native_metafile_skia_w...
printing/native_metafile_skia_wrapper.h:29: static const char*
kNativeMetafileKey;
On 2011/03/24 21:28:27, Lei Zhang wrote:
> Can't you just remove it here and instead put it in the anonymous namespace in
> native_metafile_skia_wrapper.cc?

Done.

http://codereview.chromium.org/6733036/diff/1/printing/native_metafile_skia_w...
printing/native_metafile_skia_wrapper.h:31: explicit
NativeMetafileSkiaWrapper(NativeMetafile* metafile);
On 2011/03/24 21:28:27, Lei Zhang wrote:
> nit: this goes before the member variables.

Done. (Skia does it in the other order ;-)

http://codereview.chromium.org/6733036/diff/1/printing/printing.gyp
File printing/printing.gyp (right):

http://codereview.chromium.org/6733036/diff/1/printing/printing.gyp#newcode42
printing/printing.gyp:42: 'native_metafile_skia_wrapper.h',
On 2011/03/24 21:38:15, kmadhusu wrote:
> style nit: Include them after "native_metafile.h".

I contend that the current ordering or the ordering with native_metafile.h first
is better than having native_metafile.h in the middle.  As far as I see, the
style guide is silent on the matter.

[vandebo (ex-Chrome), 2011-03-24 21:54:11]

http://codereview.chromium.org/6733036/diff/6001/printing/native_metafile_ski...
File printing/native_metafile_skia_wrapper.cc (right):

http://codereview.chromium.org/6733036/diff/6001/printing/native_metafile_ski...
printing/native_metafile_skia_wrapper.cc:37: wrapper->unref();
Fixed potential Null deref.

[Lei Zhang, 2011-03-24 21:54:12]

http://codereview.chromium.org/6733036/diff/6002/printing/native_metafile_ski...
File printing/native_metafile_skia_wrapper.cc (right):

http://codereview.chromium.org/6733036/diff/6002/printing/native_metafile_ski...
printing/native_metafile_skia_wrapper.cc:37: SkSafeUnred(wrapper);
typo :)

[vandebo (ex-Chrome), 2011-03-24 21:58:09]

http://codereview.chromium.org/6733036/diff/6002/printing/native_metafile_ski...
File printing/native_metafile_skia_wrapper.cc (right):

http://codereview.chromium.org/6733036/diff/6002/printing/native_metafile_ski...
printing/native_metafile_skia_wrapper.cc:37: SkSafeUnred(wrapper);
On 2011/03/24 21:54:12, Lei Zhang wrote:
> typo :)

Done.

[Lei Zhang, 2011-03-24 22:09:25]

LGTM