Base: A few more files using BASE_API (for base.dll)

base/base_paths.h

-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_BASE_PATHS_H_
 #define BASE_BASE_PATHS_H_
 #pragma once
 
 // This file declares path keys for the base module.  These can be used with
 // the PathService to access various special directories and files.
 
+#include "build/build_config.h"

[wtc, 2011/03/25 17:35:42]

I suspect that basictypes.h already includes build_config.h.
Also, the current recommendation is to list build_config.h
in normal alphabetical order, and then list the platform-
specific headers.  So we should say

#include "base/basictypes.h"
#include "build/build_config.h"
#if defined(OS_WIN)
#include "base/base_paths_win.h"
#elif defined(OS_MACOSX)
#include "base/base_paths_mac.h"
#endif

[rvargas (doing something else), 2011/03/25 17:59:56]

I guess I should not be touching this file at all. I guess I changed it before
realizing that basictypes depends on build_config. I'll just leave it alone (it
needs either build_config or basic_types, but not both).

+
 #include "base/basictypes.h"
 #if defined(OS_WIN)
 #include "base/base_paths_win.h"
 #elif defined(OS_MACOSX)
 #include "base/base_paths_mac.h"
 #endif
 
 namespace base {
 
 enum {
@@ skipping 17 matching lines @@
                 // This is $XDG_CACHE_HOME on Linux and
                 // ~/Library/Caches on Mac.
 #endif
 
   PATH_END
 };
 
 }  // namespace base
 
 #endif  // BASE_BASE_PATHS_H_