Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 6733005: Backlight off should not transition to dim or off states (Closed)

Created:
9 years, 9 months ago by Simon Que
Modified:
9 years, 7 months ago
Reviewers:
Benson Leung
CC:
chromium-os-reviews_chromium.org, davidjames, Benson Leung, Sameer Nanda
Visibility:
Public.

Description

Backlight off should not transition to dim or off states When backlight has been set all the way down to zero, it should not transition to the dim or off states due to idle. Otherwise, user input would cause the system to exit dim or idle and turn on the backlight. It is more important to maintain the backlight off status. BUG=chromium-os:13427 TEST=1. Set [un]plugged_dim_state and [un]plugged_off_state to 30000 in /var/lib/power_manager, restart powerd. 2. Turn brightness down to zero, wait for more than 60 seconds. 3. Press a non-brightness key or move the touchpad. 4. The backlight should remain off. Change-Id: I578f5024aa25d64a6dc2a6bf7fce51510729c640 Signed-off-by: Simon Que <sque@chromium.org>; Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=06c569f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -20 lines) Patch
M backlight_controller.cc View 1 chunk +6 lines, -1 line 0 comments Download
M powerd.cc View 1 chunk +25 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Simon Que
9 years, 9 months ago (2011-03-23 21:21:20 UTC) #1
Benson Leung
9 years, 8 months ago (2011-03-31 00:53:32 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698