Rerun configure to update linux/config.h and mac/config.h for

Rerun configure to update linux/config.h and mac/config.h for
open-vcdiff 0.7.

Linux: Ubuntu Lucid 10.04
Mac: Mac OS X 10.5 with Xcode 3.1.4

It seems that the original linux/config.h was incorrectly generated.

BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79888

[wtc, 2011-03-24 21:16:36]

evan,mark: please review this CL.

sgk: do you remember how you generated src/sdch/linux/config.h
(http://codereview.chromium.org/40101)?  It doesn't define
any macros, and the #undef MACRO lines are all commented out,
which is strange.

jar: just FYI.

[Mark Mentovai, 2011-03-24 21:20:04]

LGTM.

It actually looks like there wasn’t much wrong with the original Mac config.h.
The Linux one, on the other hand, looks completely out of whack. You should
update the checkin comment.

[wtc, 2011-03-24 21:35:14]

mark: thanks for the review.  Sorry about the typo in the checkin comment.

It should say "the original linux/config.h was incorrectly generated",
not "the original mac/config.h was incorrectly generated".  I've fixed
this typo.

[wtc, 2011-03-29 00:10:04]

Please review Patch Set 2.

linux/config.h is also used for Linux ARM, so it should
not contain i386 or x86_64 specific settings.  I found this
snippet in configure.ac:

# Built-in memcmp can be inefficient when gcc compiles for x86 processors.
# In those cases, use an alternative function instead of memcmp.
case $host_cpu in
  *86*)
    if test "$GCC" = "yes"; then
      AC_DEFINE(VCDIFF_USE_BLOCK_COMPARE_WORDS, 1,
                Use custom compare function instead of memcmp)
    fi
    ;;
esac

So I manually undefine VCDIFF_USE_BLOCK_COMPARE_WORDS
to make config.h CPU-neutral.

Note: mac/config.h doesn't need this change because
current Macs all have i386 or x86_64 CPUs, but I made
the change for consistency.  Should I undo the change?

[Mark Mentovai, 2011-03-29 01:38:56]

http://codereview.chromium.org/6732031/diff/5001/sdch/linux/config.h
File sdch/linux/config.h (right):

http://codereview.chromium.org/6732031/diff/5001/sdch/linux/config.h#newcode110
sdch/linux/config.h:110: /* #undef VCDIFF_USE_BLOCK_COMPARE_WORDS */
Rather than doing this, I’d prefer to replicate configure.ac’s logic right here
using a preprocessor conditional. That would be:

#if defined(__i386__) || defined(__x86_64__)
#define VCDIFF_USE_BLOCK_COMPARE_WORDS 1
#endif

http://codereview.chromium.org/6732031/diff/5001/sdch/mac/config.h
File sdch/mac/config.h (right):

http://codereview.chromium.org/6732031/diff/5001/sdch/mac/config.h#newcode110
sdch/mac/config.h:110: /* #undef VCDIFF_USE_BLOCK_COMPARE_WORDS */
I do like that you’ve synchronized this with the Linux change. Please continue
to do so.

[wtc, 2011-03-30 01:19:18]

mark: please review Patch Set 3.

[Mark Mentovai, 2011-03-30 01:32:08]

LGTM

[commit-bot: I haz the power, 2011-03-30 16:59:26]

Presubmit check for 6732031-9001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2011 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.\n
Found a bad license header in these files:
  sdch/linux/config.h \
  sdch/mac/config.h