Add support to check if the url has changed for a git dep and create a new clone.

Add support to check if the url has changed for a git dep and create a new clone.

BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79298

[TVL, 2011-03-24 14:38:57]

I'm still pretty scared of the remove, but I'll hope that check catches
everything that could be needed.

[TVL, 2011-03-24 14:43:19]

http://codereview.chromium.org/6732023/diff/1/gclient_scm.py
File gclient_scm.py (right):

http://codereview.chromium.org/6732023/diff/1/gclient_scm.py#newcode192
gclient_scm.py:192: self._CheckClean(rev_str)
actually, this doesn't seem to catch new files.  do we have anything to catch
that?

[M-A Ruel, 2011-03-24 14:49:42]

http://codereview.chromium.org/6732023/diff/1/gclient_scm.py
File gclient_scm.py (right):

http://codereview.chromium.org/6732023/diff/1/gclient_scm.py#newcode191
gclient_scm.py:191: print('_____ switching %s to a new checkout' % self.relpath)
to a new upstream

http://codereview.chromium.org/6732023/diff/1/gclient_scm.py#newcode193
gclient_scm.py:193: gclient_utils.RemoveDirectory(self.checkout_path)
You don't need to remove the directory at all. Something like that would make
sense:
git remote set-url origin <newurl>
git fetch origin --prune --quiet
# Then forcibly rebase master on the new origin, that needs to be tested.
git reset --hard origin/master

[TVL, 2011-03-24 15:21:45]

ok, new version up.

[M-A Ruel, 2011-03-24 17:17:02]

I'd prefer to have a quick gclient smoke test where you switch from one upstream
to another but they are not very stable though so I don't mind too much and
that's quite a corner case, if it's broken, only you will suffer :)

http://codereview.chromium.org/6732023/diff/2002/gclient_scm.py
File gclient_scm.py (right):

http://codereview.chromium.org/6732023/diff/2002/gclient_scm.py#newcode201
gclient_scm.py:201: for cmd, quiet_arg in commands:
It's funny but the following is still less lines (6 vs 9) and more readable
IMHO:

self._Run(['remote', 'set-url', 'origin', url])
quiet = []
if not options.verbose:
  quiet = ['--quiet']
self._Run(['fetch', 'origin', '--prune'] + quiet)
self._Run(['reset', '--hard', 'origin/master'] + quiet)

cwd=self.checkout_path is not necessary since it's set as default.

http://codereview.chromium.org/6732023/diff/2002/gclient_scm.py#newcode206
gclient_scm.py:206: files = self._Capture(['ls-files']).split()
splitlines() ?

[TVL, 2011-03-24 17:43:11]

re unittest - if they actually ran on all platforms, I'd try, but the don't seem
to run on the platform i'm editing on.

http://codereview.chromium.org/6732023/diff/2002/gclient_scm.py
File gclient_scm.py (right):

http://codereview.chromium.org/6732023/diff/2002/gclient_scm.py#newcode201
gclient_scm.py:201: for cmd, quiet_arg in commands:
On 2011/03/24 17:17:02, Marc-Antoine Ruel wrote:
> It's funny but the following is still less lines (6 vs 9) and more readable
> IMHO:
> 
> self._Run(['remote', 'set-url', 'origin', url])
> quiet = []
> if not options.verbose:
>   quiet = ['--quiet']
> self._Run(['fetch', 'origin', '--prune'] + quiet)
> self._Run(['reset', '--hard', 'origin/master'] + quiet)
> 
> cwd=self.checkout_path is not necessary since it's set as default.

Done.  (help didn't list --quiet as valid for reset, only listed -q)

http://codereview.chromium.org/6732023/diff/2002/gclient_scm.py#newcode206
gclient_scm.py:206: files = self._Capture(['ls-files']).split()
On 2011/03/24 17:17:02, Marc-Antoine Ruel wrote:
> splitlines() ?

I just copied what 222-223 do for a fresh clone, should both change?

[M-A Ruel, 2011-03-24 17:49:26]

On 2011/03/24 17:43:11, TVL wrote:
> Done.  (help didn't list --quiet as valid for reset, only listed -q)

What git version? Can you try locally? Because here both are listed.

http://codereview.chromium.org/6732023/diff/2002/gclient_scm.py#newcode206
> gclient_scm.py:206: files = self._Capture(['ls-files']).split()
> On 2011/03/24 17:17:02, Marc-Antoine Ruel wrote:
> > splitlines() ?
> 
> I just copied what 222-223 do for a fresh clone, should both change?

yes.

[TVL, 2011-03-24 17:55:18]

On 2011/03/24 17:49:26, Marc-Antoine Ruel wrote:
> On 2011/03/24 17:43:11, TVL wrote:
> > Done.  (help didn't list --quiet as valid for reset, only listed -q)
> 
> What git version? Can you try locally? Because here both are listed.
> 

       git reset [-q] [<commit>] [--] <paths>...
       git reset --patch [<commit>] [--] [<paths>...]
       git reset [--soft | --mixed | --hard | --merge | --keep] [-q] [<commit>]

$ git version
git version 1.7.3.2

it seems to work fine, just wasn't listed.

> http://codereview.chromium.org/6732023/diff/2002/gclient_scm.py#newcode206
> > gclient_scm.py:206: files = self._Capture(['ls-files']).split()
> > On 2011/03/24 17:17:02, Marc-Antoine Ruel wrote:
> > > splitlines() ?
> > 
> > I just copied what 222-223 do for a fresh clone, should both change?
> 
> yes.

[M-A Ruel, 2011-03-24 17:58:11]

lgtm