Refactor monitor_reconfigure to stop using system("xrandr").

resolution_selector.h

 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MONITOR_RECONFIGURE_RESOLUTION_SELECTOR_H_
 #define MONITOR_RECONFIGURE_RESOLUTION_SELECTOR_H_
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 
 namespace monitor_reconfig {
 
 // ResolutionSelector takes the sets of resolutions supported by the
 // built-in and external displays as input and attempts to choose a shared
 // resolution that will work well on both devices.
 class ResolutionSelector {
  public:
   // A single mode supported by a device, equivalent to the XRRModeInfo
   // struct.
   struct Mode {
-    Mode(int width, int height, std::string name)
+    Mode(int width = 0, int height = 0, std::string name = "", int id = 0)

[Daniel Erat, 2011/03/24 23:02:11]

the style guide doesn't allow default arguments:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Default_Arguments

         : width(width),
           height(height),
-          name(name) {
+          name(name),
+          id(id) {
     }
 
     // Mode's dimensions.
     int width;
     int height;
 
     // Mode's name from XRandR.  This uniquely describes the mode and can
     // be used to set the devices's resolution later.
     std::string name;
+
+    // The mode id, used for setting this mode
+    unsigned id;
   };
 
   // Maximum screen size for the external output at which we assume that
   // it's a projector (as opposed to a monitor) and try to find a size that
   // will also fit on the LCD display.  Above this, we just use the
   // external output's maximum resolution, even if it doesn't fit on the
   // LCD.
   static const int kMaxProjectorPixels;
 
   ResolutionSelector() {}
   ~ResolutionSelector() {}
 
   // Comparator used to sort Mode objects.
   // Returns true if |mode_a| has more pixels than |mode_b| and false otherwise.
   class ModeResolutionComparator {
    public:
     bool operator()(const Mode& mode_a, const Mode& mode_b) const {
       return mode_a.width * mode_a.height > mode_b.width * mode_b.height;
     }
   };
 
   // Find the "best" resolutions for various outputs.
   // The returned strings contain |name| values from the passed-in modes.

[Daniel Erat, 2011/03/24 23:02:11]

update the bit about strings here; it's no longer accurate

   bool FindBestResolutions(
       const std::vector<Mode>& lcd_modes,
       const std::vector<Mode>& external_modes,
-      std::string* lcd_resolution,
-      std::string* external_resolution,
-      std::string* screen_resolution);
+      Mode* lcd_resolution,
+      Mode* external_resolution,
+      Mode* screen_resolution);
 
  private:
   // Find resolutions to use that are reasonably close together.
   // |larger_device_modes| and |smaller_device_modes| should be sorted by
   // descending resolution.  We choose the highest resolution from
   // |smaller_device_modes| and the lowest resolution from |larger_device_modes|
   // that's at least as high as the resolution from the smaller device.
   // |screen_resolution| gets set to |smaller_resolution| to avoid clipping.
   bool FindNearestResolutions(
       const std::vector<Mode>& larger_device_modes,
       const std::vector<Mode>& smaller_device_modes,
-      std::string* larger_resolution,
-      std::string* smaller_resolution,
-      std::string* screen_resolution);
+      Mode* larger_resolution,
+      Mode* smaller_resolution,
+      Mode* screen_resolution);
 
   DISALLOW_COPY_AND_ASSIGN(ResolutionSelector);
 };
 
 }  // namespace monitor_reconfig
 
 #endif  // MONITOR_RECONFIGURE_RESOLUTION_SELECTOR_H_