Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2428)

Unified Diff: chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h

Issue 6732007: Native menu implementation for bug 5679. Followup to http://codereview.chromium.org/2928005/ Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: More code review updates. Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h
diff --git a/chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h b/chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h
index a72304b7d6bc789126151f944150ab07b4f78671..0b40031fd8bed7ff30fa8fde3bd14815b0c5ab6e 100644
--- a/chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h
+++ b/chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h
@@ -14,6 +14,11 @@
@class MenuButton;
+namespace BackForwardMenuControllerInternal {
+// A C++ delegate that handles favicons as they are loaded from history.
+class MenuDelegate;
+}
+
typedef BackForwardMenuModel::ModelType BackForwardMenuType;
const BackForwardMenuType BACK_FORWARD_MENU_TYPE_BACK =
BackForwardMenuModel::BACKWARD_MENU;
@@ -29,6 +34,8 @@ const BackForwardMenuType BACK_FORWARD_MENU_TYPE_FORWARD =
MenuButton* button_; // Weak; comes from nib.
scoped_ptr<BackForwardMenuModel> model_;
scoped_nsobject<NSMenu> backForwardMenu_;
+ scoped_ptr<BackForwardMenuControllerInternal::MenuDelegate>
+ contextMenuDelegate_;
}
// Type (back or forwards); can only be set on initialization.
@@ -37,6 +44,7 @@ const BackForwardMenuType BACK_FORWARD_MENU_TYPE_FORWARD =
- (id)initWithBrowser:(Browser*)browser
modelType:(BackForwardMenuType)type
button:(MenuButton*)button;
+- (void)onIconChanged:(int)modelIndex;
@end // @interface BackForwardMenuController
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.mm » ('j') | chrome/browser/ui/gtk/menu_gtk.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698