Issue 6731096: Patched the new version of SCons to work around a Mac+Python+Toolchain bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6731096: Patched the new version of SCons to work around a Mac+Python+Toolchain bug. (Closed)

Created:
9 years, 8 months ago by Nick Bray

Modified:
9 years, 7 months ago

Reviewers:
Mark Seaborn, bradn

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/third_party/

Visibility:
Public.

Description

Patched the new version of SCons to work around a Mac+Python+Toolchain bug. BUG= http://code.google.com/p/nativeclient/issues/detail?id=1250 TEST= none (bugfix for a to-be-commited CL) Committed: http://code.google.com/p/nativeclient/source/detail?r=4664

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	scons-2.0.1/README.nacl	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	scons-2.0.1/script/scons	View	1 2	1 chunk	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

9 years, 8 months ago (2011-03-30 20:07:13 UTC) #2

LGTM but please fix nits below.

http://codereview.chromium.org/6731096/diff/1/scons-2.0.1/script/scons
File scons-2.0.1/script/scons (right):

http://codereview.chromium.org/6731096/diff/1/scons-2.0.1/script/scons#newcod...
scons-2.0.1/script/scons:166: # An ImportError
add "or" on the end?

http://codereview.chromium.org/6731096/diff/1/scons-2.0.1/script/scons#newcod...
scons-2.0.1/script/scons:167: # A distutils.errors.DistutilsPlatformError
You told me that this is considered a Python bug which is fixed upstream in a
newer Python.  Could you link to that here?

http://codereview.chromium.org/6731096/diff/1/scons-2.0.1/script/scons#newcod...
scons-2.0.1/script/scons:168: # Vanila SCons only catches an ImportError.
"vanilla"

http://codereview.chromium.org/6731096/diff/1/scons-2.0.1/script/scons#newcod...
scons-2.0.1/script/scons:169: # The other exception gets throw on the mac
toolchain bot because it
mac -> Mac

Expand Messages | Collapse Messages