Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Issue 6731067: flimflam: revise multi-profile support to pin objects to a profile (Closed)

Created:
9 years, 9 months ago by Sam Leffler
Modified:
9 years, 7 months ago
Reviewers:
Paul Stewart
CC:
chromium-os-reviews_chromium.org, sleffler+cc_chromium.org, Nathan Williams, Eric Shienbrood, Jason Glasgow, rochberg, Paul Stewart, zel, stevenjb
Visibility:
Public.

Description

flimflam: revise multi-profile support to pin objects to a profile Change the way profiles are managed: instead of binding a service to the active profile at create time, bind it to a profile on first load/save. Also add a Profile property to the service object and support setting it via D-bus (potentially moving an entry from one profile to another). Other objects are always written to a global profile (if any); this includes devices, ipconfig, and global settings (e.g. OfflineMode). As part of this change make the profile write logic per-profile so multiple profiles may be pending simultaneously. Also adds notifiers for profile push/pop (used only by service now but could be used if other objects need to be aware). BUG=chromium-os:12948 TEST=manual:clear the global profile; login and join GoogleGuest; verify the entry is written to the user profile; logout and verify we disconnect; login again and verify we autoconnect to GoogleGuest; also use list-services to check Profile property and set-service-property to manually move profile binding of a service (checking raw profile data on disk) Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f018bcd

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix handling of profile updates w/o a profile #

Patch Set 3 : fix diff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -145 lines) Patch
M doc/service-api.txt View 2 chunks +0 lines, -6 lines 0 comments Download
M include/notifier.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/connman.h View 4 chunks +12 lines, -2 lines 0 comments Download
M src/manager.c View 1 chunk +0 lines, -2 lines 0 comments Download
M src/notifier.c View 2 chunks +28 lines, -2 lines 0 comments Download
M src/profile.c View 1 15 chunks +177 lines, -105 lines 0 comments Download
M src/service.c View 1 2 20 chunks +116 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sam Leffler
Think this is finally ready. Once LGTM'd I plan to commit w/o enabling the push/pop ...
9 years, 9 months ago (2011-03-29 22:20:27 UTC) #1
Paul Stewart
LGTM w/itty nit http://codereview.chromium.org/6731067/diff/1/src/profile.c File src/profile.c (right): http://codereview.chromium.org/6731067/diff/1/src/profile.c#newcode63 src/profile.c:63: * Service objects go to the ...
9 years, 9 months ago (2011-03-30 00:56:18 UTC) #2
Sam Leffler
PTAL My changes to handle multiple profiles simultaneously being updated broke the case where no ...
9 years, 8 months ago (2011-03-31 23:35:04 UTC) #3
Paul Stewart
9 years, 8 months ago (2011-04-01 19:11:13 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698