Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: content/common/file_path_watcher/file_path_watcher_inotify.cc

Issue 6731064: kqueue implementation of FilePathWatcher on Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Xcode didn't save some files, so win and linux changes missed Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/file_path_watcher/file_path_watcher_inotify.cc
diff --git a/content/common/file_path_watcher/file_path_watcher_inotify.cc b/content/common/file_path_watcher/file_path_watcher_inotify.cc
index 50d734288a105c463a2de7bdd81ba2900db37047..f91756f6efe8d20493f849c76ac63e9f9a392756 100644
--- a/content/common/file_path_watcher/file_path_watcher_inotify.cc
+++ b/content/common/file_path_watcher/file_path_watcher_inotify.cc
@@ -98,8 +98,7 @@ class FilePathWatcherImpl : public FilePathWatcher::PlatformDelegate,
// Start watching |path| for changes and notify |delegate| on each change.
// Returns true if watch for |path| has been added successfully.
virtual bool Watch(const FilePath& path,
- FilePathWatcher::Delegate* delegate,
- base::MessageLoopProxy* loop) OVERRIDE;
+ FilePathWatcher::Delegate* delegate) OVERRIDE;
// Cancel the watch. This unregisters the instance with InotifyReader.
virtual void Cancel() OVERRIDE;
@@ -345,7 +344,7 @@ void FilePathWatcherImpl::OnFilePathChanged(
// Update watches if a directory component of the |target_| path (dis)appears.
if (is_directory && change_on_target_path && !UpdateWatches()) {
- delegate_->OnError();
+ delegate_->OnFilePathError(target_);
return;
}
@@ -364,8 +363,7 @@ void FilePathWatcherImpl::OnFilePathChanged(
}
bool FilePathWatcherImpl::Watch(const FilePath& path,
- FilePathWatcher::Delegate* delegate,
- base::MessageLoopProxy*) {
+ FilePathWatcher::Delegate* delegate) {
DCHECK(target_.empty());
DCHECK(MessageLoopForIO::current());

Powered by Google App Engine
This is Rietveld 408576698