Issue 6731060: Move WebUIFactory to chrome/, try 2.

Issue 6731060: Move WebUIFactory to chrome/, try 2. (Closed)

Created:
9 years, 9 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., jam, Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move WebUIFactory to chrome/, try 2. first try was r79691 This fixes the SiteInstance unit test failure. SiteInstance has all kinds of dependencies into chrome/. This fixes the unittest just enough to get it passing without trying to refactor SiteInstance at all. BUG=77092 TEST=trybots, again Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79849

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+704 lines, -450 lines)			Patch
M	chrome/browser/browser_url_handler.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/favicon_service.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/notifications/balloon_host.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon_host.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/prerender/prerender_contents.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/background_contents.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/background_contents.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_delegate_helper.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser_navigator.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
A	chrome/browser/ui/webui/chrome_web_ui_factory.h	View		1 chunk	+51 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/webui/chrome_web_ui_factory.cc	View		1 chunk	+359 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/browsing_instance.cc	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	content/browser/content_browser_client.h	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
A	content/browser/content_browser_client.cc	View	1 2	1 chunk	+17 lines, -0 lines	0 comments	Download
M	content/browser/site_instance.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	content/browser/site_instance_unittest.cc	View	1	3 chunks	+51 lines, -16 lines	0 comments	Download
M	content/browser/tab_contents/render_view_host_manager.cc	View		3 chunks	+7 lines, -4 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.h	View		4 chunks	+6 lines, -3 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View		8 chunks	+19 lines, -13 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents_view.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
A	content/browser/webui/empty_web_ui_factory.h	View		1 chunk	+38 lines, -0 lines	0 comments	Download
A	content/browser/webui/empty_web_ui_factory.cc	View		1 chunk	+44 lines, -0 lines	0 comments	Download
A +	content/browser/webui/generic_handler.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	content/browser/webui/generic_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/webui/web_ui.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	content/browser/webui/web_ui.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	content/browser/webui/web_ui_factory.h	View		1 chunk	+37 lines, -48 lines	0 comments	Download
M	content/browser/webui/web_ui_factory.cc	View	1 2	1 chunk	+6 lines, -336 lines	0 comments	Download
M	content/content_browser.gypi	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download