Issue 6731056: Update to test scripts to work with both ModemManager and Cromo

Issue 6731056: Update to test scripts to work with both ModemManager and Cromo (Closed)

Created:
9 years, 8 months ago by Jason Glasgow

Modified:
9 years, 7 months ago

Reviewers:
rochberg

CC:
chromium-os-reviews_chromium.org, sleffler+cc_chromium.org, Nathan Williams, Eric Shienbrood, Jason Glasgow, Paul Stewart

Base URL:
ssh://gitrw.chromium.org:9222/flimflam.git@master

Visibility:
Public.

Description

Update to test scripts to work with both ModemManager and Cromo BUG=chromium-os:12509 TEST=run all scripts by hand, run suite_Cellular Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b9582b4

Patch Set 3 : Fix review comments #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -64 lines)			Patch
M	test/mm.py	View	1 2	3 chunks	+63 lines, -22 lines	0 comments	Download
M	test/mm-activate	View	1 2	2 chunks	+6 lines, -3 lines	0 comments	Download
M	test/mm-connect	View	1 2	2 chunks	+10 lines, -6 lines	0 comments	Download
M	test/mm-disable	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	test/mm-disconnect	View	1	3 chunks	+9 lines, -6 lines	0 comments	Download
M	test/mm-enable	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	test/mm-factory-reset	View	1 2	2 chunks	+6 lines, -3 lines	0 comments	Download
M	test/mm-list-modems	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	test/mm-poll-signal-strength	View	1 2	2 chunks	+5 lines, -2 lines	0 comments	Download
M	test/mm-register	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	test/mm-reset	View	1 2	2 chunks	+6 lines, -3 lines	0 comments	Download
M	test/mm-set-carrier	View		2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rochberg

http://codereview.chromium.org/6731056/diff/2001/test/mm-factory-reset File test/mm-factory-reset (right): http://codereview.chromium.org/6731056/diff/2001/test/mm-factory-reset#newcode26 test/mm-factory-reset:26: (manager, path) = mm.PickOneModem(modem_pattern) Sometimes you don't use these ...

9 years, 8 months ago (2011-03-30 00:23:54 UTC) #3

Jason Glasgow

9 years, 8 months ago (2011-03-30 14:44:47 UTC) #4

PTAL

http://codereview.chromium.org/6731056/diff/2001/test/mm-factory-reset
File test/mm-factory-reset (right):

http://codereview.chromium.org/6731056/diff/2001/test/mm-factory-reset#newcode26
test/mm-factory-reset:26: (manager, path) = mm.PickOneModem(modem_pattern)
On 2011/03/30 00:23:54, rochberg wrote:
> Sometimes you don't use these parens

Done.

http://codereview.chromium.org/6731056/diff/2001/test/mm.py
File test/mm.py (right):

http://codereview.chromium.org/6731056/diff/2001/test/mm.py#newcode132
test/mm.py:132: if not len(matches):
On 2011/03/30 00:23:54, rochberg wrote:
> not matches

Done.

http://codereview.chromium.org/6731056/diff/2001/test/mm.py#newcode136
test/mm.py:136: ", ".join([path for m, path in matches]))
On 2011/03/30 00:23:54, rochberg wrote:
> for _, path

Done.

Expand Messages | Collapse Messages